Fix Zero3 contiguous grads, reduce scatter false accuracy issue#4321
Merged
tjruwase merged 2 commits intodeepspeedai:masterfrom Sep 14, 2023
Merged
Fix Zero3 contiguous grads, reduce scatter false accuracy issue#4321tjruwase merged 2 commits intodeepspeedai:masterfrom
tjruwase merged 2 commits intodeepspeedai:masterfrom
Conversation
it is a corner case met when running Zero3 on flan-t5 HF model. Where HF auto bucket size becomes exactly the same size if hidden_size^2 This is the exact size of some of the params. due to the bug the params are not being reduced during backward.
nelyahu
requested review from
jeffra,
mrwyattii,
samyam and
tjruwase
as code owners
tjruwase
approved these changes
Sep 14, 2023
CurryRice233
added a commit
to CurryRice233/DeepSpeed
that referenced
this pull request
Sep 15, 2023
* origin/master: (48 commits) Fix autotune to support Triton 2.1 (deepspeedai#4340) Fix skipped inference tests (deepspeedai#4336) Suppress noise (deepspeedai#4310) Fix a bug in the implementation of dequantization for inference (deepspeedai#3433) DS-Chat BLOOM: Fix Attention mask (deepspeedai#4338) clear redundant timers (deepspeedai#4308) Add release version checking (deepspeedai#4328) Fix Zero3 contiguous grads, reduce scatter false accuracy issue (deepspeedai#4321) Clean up modeling code (deepspeedai#4320) Handle empty parameter groups (deepspeedai#4277) Update README.md (deepspeedai#4316) README update (deepspeedai#4303) Update release and bump patch versioning flow (deepspeedai#4286) added a bert-model check for triton (deepspeedai#4266) ZeRO-Inference v2 release bump to 0.10.4 Update index.md (deepspeedai#4297) fix user args parsing of string with spaces on runner (deepspeedai#4265) ZeRO-Inference refresh (deepspeedai#4197) AMD Kernel Compatibility Fixes (deepspeedai#3180) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is a corner case met when running Zero3 on flan-t5 HF model. Where HF auto bucket size becomes exactly the same size if hidden_size^2 This is the exact size of some of the params. due to the bug the params are not being reduced during backward.