Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up journey test for build #1361

Closed
cmwylie19 opened this issue Oct 30, 2024 · 0 comments · Fixed by #1449
Closed

Clean up journey test for build #1361

cmwylie19 opened this issue Oct 30, 2024 · 0 comments · Fixed by #1449
Labels
tech-debt
Milestone
v0.40.0

Comments

@cmwylie19
Copy link
Collaborator

cmwylie19 commented Oct 30, 2024 •
edited
Loading

Describe what should be investigated or refactored

Running the journey test results in a child folder being published when the Pepr test module comes up. We need to delete this in an afterAll block.

dist/pepr-test-module/child/folder

There are also unused variables

image
@cmwylie19 cmwylie19 changed the title Remove child folder after running journey test Clean up journey test for build Oct 30, 2024
@cmwylie19 cmwylie19 modified the milestones: v0.39.0, v0.40.0 Nov 6, 2024
@cmwylie19 cmwylie19 modified the milestone: v0.40.0 Nov 20, 2024
@cmwylie19 cmwylie19 mentioned this issue Nov 20, 2024
Merged
5 tasks
cmwylie19 added a commit that referenced this issue Nov 20, 2024
@cmwylie19
chore: test cleanup of unneeded folders (#1449)
5d85820 
## Description

When running `npm test` the `pepr-test-module` is created with journey
tests are run on module. This is a common place to test new features in
the controller. However, there was legacy folders being left in the
`dist` folder after the test ended. This PR cleans up the legacy folders
that are no longer needed after the test ends and not relevant for
controller testing.

End to End Test:  <!-- if applicable -->  
(See [Pepr Excellent
Examples](https://github.com/defenseunicorns/pepr-excellent-examples))

## Related Issue

Fixes #1361 
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging
- [x] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Pepr Project Board Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech-debt
Projects
Pepr Project Board
Status: ✅ Done
Milestone
v0.40.0
Development

Successfully merging a pull request may close this issue.

chore: test cleanup of unneeded folders defenseunicorns/pepr
1 participant
@cmwylie19