Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ability to exit Finalize() callback WITHOUT removing the finalizer #1321

Merged
merged 5 commits into from
Oct 28, 2024

Conversation

btlghrants
Copy link
Contributor

@btlghrants btlghrants commented Oct 23, 2024

Description

Adds ability for Module Author to "opt out" of removing Pepr's metadata.finalizers entry.

End to End Test:
pepr-excellent-examples #172

Related Issue

Fixes #1316

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@btlghrants btlghrants self-assigned this Oct 23, 2024
Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 85.64%. Comparing base (055a8f4) to head (2e4d970).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/watch-processor.ts 0.00% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1321      +/-   ##
==========================================
- Coverage   86.00%   85.64%   -0.36%     
==========================================
  Files          31       31              
  Lines        1443     1449       +6     
  Branches      339      319      -20     
==========================================
  Hits         1241     1241              
- Misses        184      206      +22     
+ Partials       18        2      -16     
Files with missing lines Coverage Δ
src/lib/capability.ts 94.90% <100.00%> (ø)
src/lib/types.ts 100.00% <ø> (ø)
src/lib/watch-processor.ts 79.20% <0.00%> (-5.01%) ⬇️

... and 3 files with indirect coverage changes

@btlghrants btlghrants marked this pull request as ready for review October 23, 2024 22:09
@btlghrants btlghrants requested a review from a team as a code owner October 23, 2024 22:09
@cmwylie19 cmwylie19 merged commit 7bc80d5 into main Oct 28, 2024
45 of 46 checks passed
@cmwylie19 cmwylie19 deleted the 1316_finalize_early_exit branch October 28, 2024 12:20
@cmwylie19 cmwylie19 added this to the v0.39.0 milestone Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add ability to exit Finalize() callback WITHOUT removing the finalizer
3 participants