chore: test artifacts before publish #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TristanHoladay
changed the title
|
currently some extra conditionals to not deploy the arm packages. should we start an issue for adding arm testing to our workflows? |
mjnagel
requested changes
Mar 7, 2024
There was a problem hiding this comment.
I like the matrix approach in general but one of my concerns with this currently is parallelizing the architecture publishes. Maybe not critical but currently this would publish the arm64 packages regardless of whether or not amd64 testing fails I think? I don't think we necessarily need to test the arm build in CI, but it would be good to only publish when the test succeeds. We could just switch back to publishing both in the same task and drop arch from the matrix, but might be other approaches that are more optimal.
mjnagel
requested changes
Mar 8, 2024
mjnagel
approved these changes
Mar 8, 2024
mjnagel
pushed a commit
that referenced
this pull request
Mar 15, 2024
🤖 I have created a release *beep* *boop* --- ## [0.16.0](v0.15.1...v0.16.0) (2024-03-15) ### Features * add velero package ([#210](#210)) ([a272945](a272945)) * **operator:** add events and improve lifecycle ops ([#245](#245)) ([502c044](502c044)) ### Bug Fixes * ocsp lookup egress policy ([#255](#255)) ([77c38f2](77c38f2)) ### Miscellaneous * add flavor to pepr build task ([#238](#238)) ([29bf8a3](29bf8a3)) * **deps:** update grafana ([#144](#144)) ([6987927](6987927)) * **deps:** update neuvector ([#73](#73)) ([50f6c90](50f6c90)) * test artifacts before publish ([#198](#198)) ([9732f32](9732f32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.16.0](defenseunicorns/uds-core@v0.15.1...v0.16.0) (2024-03-15) ### Features * add velero package ([#210](defenseunicorns/uds-core#210)) ([a272945](defenseunicorns/uds-core@a272945)) * **operator:** add events and improve lifecycle ops ([#245](defenseunicorns/uds-core#245)) ([502c044](defenseunicorns/uds-core@502c044)) ### Bug Fixes * ocsp lookup egress policy ([#255](defenseunicorns/uds-core#255)) ([77c38f2](defenseunicorns/uds-core@77c38f2)) ### Miscellaneous * add flavor to pepr build task ([#238](defenseunicorns/uds-core#238)) ([29bf8a3](defenseunicorns/uds-core@29bf8a3)) * **deps:** update grafana ([#144](defenseunicorns/uds-core#144)) ([6987927](defenseunicorns/uds-core@6987927)) * **deps:** update neuvector ([#73](defenseunicorns/uds-core#73)) ([50f6c90](defenseunicorns/uds-core@50f6c90)) * test artifacts before publish ([#198](defenseunicorns/uds-core#198)) ([9732f32](defenseunicorns/uds-core@9732f32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
## Description Test artifacts before publishing them to make sure nothing has changed with upstream or ironbank images. ## Related Issue Resolves #150 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md)(https://github.com/defenseunicorns/uds-template-capability/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed --------- Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.16.0](v0.15.1...v0.16.0) (2024-03-15) ### Features * add velero package ([#210](#210)) ([a272945](a272945)) * **operator:** add events and improve lifecycle ops ([#245](#245)) ([502c044](502c044)) ### Bug Fixes * ocsp lookup egress policy ([#255](#255)) ([77c38f2](77c38f2)) ### Miscellaneous * add flavor to pepr build task ([#238](#238)) ([29bf8a3](29bf8a3)) * **deps:** update grafana ([#144](#144)) ([6987927](6987927)) * **deps:** update neuvector ([#73](#73)) ([50f6c90](50f6c90)) * test artifacts before publish ([#198](#198)) ([9732f32](9732f32)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test artifacts before publishing them to make sure nothing has changed with upstream or ironbank images.
Related Issue
Resolves #150
Type of change
Checklist before merging