chore: add keycloak to dev bundle and rename #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… flag for just istio
zachariahmiller
changed the title
|
Will update to fix linting errors and add a couple lines to to docs in a bit, but if there is other feedback to address lmk |
MxNxPx
previously approved these changes
Mar 15, 2024
mjnagel
reviewed
Mar 15, 2024
mjnagel
requested changes
Mar 19, 2024
Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
|
@mjnagel Updated with your suggested changes and re-requested review. Assuming CI passes, which it should, I will go ahead and update the pr description and title after this next meeting. |
zachariahmiller
changed the title
zachariahmiller
changed the title
|
@mjnagel i resolved your comments and updated the description and pr title. |
mjnagel
reviewed
Mar 19, 2024
There was a problem hiding this comment.
(last one I promise) this readme should be updated to the new name/description.
mjnagel
approved these changes
Mar 19, 2024
mjnagel
changed the title
jeff-mccoy
pushed a commit
that referenced
this pull request
Mar 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.17.0](v0.16.1...v0.17.0) (2024-03-22) ### Features * introduce sso secret templating ([#276](#276)) ([e0832ec](e0832ec)) ### Bug Fixes * add keycloak to dev bundle and rename ([#262](#262)) ([f9b905c](f9b905c)) * registration robot check form id ([#269](#269)) ([c6419b9](c6419b9)) * sticky sessions for keycloak in ha ([#281](#281)) ([5ccd557](5ccd557)) ### Miscellaneous * align mutation annotations ([#268](#268)) ([f18ad4d](f18ad4d)) * **deps:** update loki ([#209](#209)) ([03ca499](03ca499)) * **deps:** update pepr to v0.28.6 ([#254](#254)) ([54ef7de](54ef7de)) * **deps:** update zarf to v0.32.5 ([#243](#243)) ([ee93612](ee93612)) * typo fix in README.md ([#280](#280)) ([f9727e0](f9727e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.17.0](defenseunicorns/uds-core@v0.16.1...v0.17.0) (2024-03-22) ### Features * introduce sso secret templating ([#276](defenseunicorns/uds-core#276)) ([e0832ec](defenseunicorns/uds-core@e0832ec)) ### Bug Fixes * add keycloak to dev bundle and rename ([#262](defenseunicorns/uds-core#262)) ([f9b905c](defenseunicorns/uds-core@f9b905c)) * registration robot check form id ([#269](defenseunicorns/uds-core#269)) ([c6419b9](defenseunicorns/uds-core@c6419b9)) * sticky sessions for keycloak in ha ([#281](defenseunicorns/uds-core#281)) ([5ccd557](defenseunicorns/uds-core@5ccd557)) ### Miscellaneous * align mutation annotations ([#268](defenseunicorns/uds-core#268)) ([f18ad4d](defenseunicorns/uds-core@f18ad4d)) * **deps:** update loki ([#209](defenseunicorns/uds-core#209)) ([03ca499](defenseunicorns/uds-core@03ca499)) * **deps:** update pepr to v0.28.6 ([#254](defenseunicorns/uds-core#254)) ([54ef7de](defenseunicorns/uds-core@54ef7de)) * **deps:** update zarf to v0.32.5 ([#243](defenseunicorns/uds-core#243)) ([ee93612](defenseunicorns/uds-core@ee93612)) * typo fix in README.md ([#280](defenseunicorns/uds-core#280)) ([f9727e0](defenseunicorns/uds-core@f9727e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
## Description This change replaces the core-istio bundle with a dev-slim bundle that includes keycloak in addition to istio and pepr. ## Related Issue #251 --------- Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.17.0](v0.16.1...v0.17.0) (2024-03-22) ### Features * introduce sso secret templating ([#276](#276)) ([e0832ec](e0832ec)) ### Bug Fixes * add keycloak to dev bundle and rename ([#262](#262)) ([f9b905c](f9b905c)) * registration robot check form id ([#269](#269)) ([c6419b9](c6419b9)) * sticky sessions for keycloak in ha ([#281](#281)) ([5ccd557](5ccd557)) ### Miscellaneous * align mutation annotations ([#268](#268)) ([f18ad4d](f18ad4d)) * **deps:** update loki ([#209](#209)) ([03ca499](03ca499)) * **deps:** update pepr to v0.28.6 ([#254](#254)) ([54ef7de](54ef7de)) * **deps:** update zarf to v0.32.5 ([#243](#243)) ([ee93612](ee93612)) * typo fix in README.md ([#280](#280)) ([f9727e0](f9727e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change replaces the core-istio bundle with a dev-slim bundle that includes keycloak in addition to istio and pepr.
Related Issue
#251