feat: introduce sso secret templating #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjnagel
reviewed
Mar 21, 2024
mjnagel
reviewed
Mar 21, 2024
There was a problem hiding this comment.
Only other comment - would be good to have some tests on this functionality, I think @TristanHoladay has some stuff in flight to add there.
|
As discussed earlier today with @mjnagel and @rjferguson21 , i wanted to test from the top entrypoint -- |
mjnagel
approved these changes
Mar 22, 2024
jeff-mccoy
pushed a commit
that referenced
this pull request
Mar 22, 2024
🤖 I have created a release *beep* *boop* --- ## [0.17.0](v0.16.1...v0.17.0) (2024-03-22) ### Features * introduce sso secret templating ([#276](#276)) ([e0832ec](e0832ec)) ### Bug Fixes * add keycloak to dev bundle and rename ([#262](#262)) ([f9b905c](f9b905c)) * registration robot check form id ([#269](#269)) ([c6419b9](c6419b9)) * sticky sessions for keycloak in ha ([#281](#281)) ([5ccd557](5ccd557)) ### Miscellaneous * align mutation annotations ([#268](#268)) ([f18ad4d](f18ad4d)) * **deps:** update loki ([#209](#209)) ([03ca499](03ca499)) * **deps:** update pepr to v0.28.6 ([#254](#254)) ([54ef7de](54ef7de)) * **deps:** update zarf to v0.32.5 ([#243](#243)) ([ee93612](ee93612)) * typo fix in README.md ([#280](#280)) ([f9727e0](f9727e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
bburky
reviewed
Mar 25, 2024
Comment on lines
+55
to
56
| Store.removeItem(ref); | ||
| await apiCall({ clientId }, "DELETE", token); |
There was a problem hiding this comment.
Not sure which order of these is best, I think I would put Store.removeItem(ref); after await apiCall() and wrap both of these in a try/catch. It looks like there's no error handling at the moment and the error won't be caught.
Need to decide what behavior you want in case of Keycloak API errors. My suggestion would be to not drop the client from the store unless the DELETE succeeds. Unsure what's best, if it goes wrong someone may need to manually drop the item and I don't think it's really possible to hack the Pepr store directly. Deleting an item from the .spec manually is possible though, I don't think the client names are stored there though?
robmcelvenny
pushed a commit
to owen-grady/uds-core-slim-dev
that referenced
this pull request
Jun 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.17.0](defenseunicorns/uds-core@v0.16.1...v0.17.0) (2024-03-22) ### Features * introduce sso secret templating ([#276](defenseunicorns/uds-core#276)) ([e0832ec](defenseunicorns/uds-core@e0832ec)) ### Bug Fixes * add keycloak to dev bundle and rename ([#262](defenseunicorns/uds-core#262)) ([f9b905c](defenseunicorns/uds-core@f9b905c)) * registration robot check form id ([#269](defenseunicorns/uds-core#269)) ([c6419b9](defenseunicorns/uds-core@c6419b9)) * sticky sessions for keycloak in ha ([#281](defenseunicorns/uds-core#281)) ([5ccd557](defenseunicorns/uds-core@5ccd557)) ### Miscellaneous * align mutation annotations ([#268](defenseunicorns/uds-core#268)) ([f18ad4d](defenseunicorns/uds-core@f18ad4d)) * **deps:** update loki ([#209](defenseunicorns/uds-core#209)) ([03ca499](defenseunicorns/uds-core@03ca499)) * **deps:** update pepr to v0.28.6 ([#254](defenseunicorns/uds-core#254)) ([54ef7de](defenseunicorns/uds-core@54ef7de)) * **deps:** update zarf to v0.32.5 ([#243](defenseunicorns/uds-core#243)) ([ee93612](defenseunicorns/uds-core@ee93612)) * typo fix in README.md ([#280](defenseunicorns/uds-core#280)) ([f9727e0](defenseunicorns/uds-core@f9727e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
This PR introduces SSO secret templating within the UDS Operator. This allows dynamic property bindings for the secret and custom file types such as nested JSON, YAML, etc. Fixes #263  --------- Co-authored-by: TristanHoladay <40547442+TristanHoladay@users.noreply.github.com>
rjferguson21
pushed a commit
that referenced
this pull request
Jul 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.17.0](v0.16.1...v0.17.0) (2024-03-22) ### Features * introduce sso secret templating ([#276](#276)) ([e0832ec](e0832ec)) ### Bug Fixes * add keycloak to dev bundle and rename ([#262](#262)) ([f9b905c](f9b905c)) * registration robot check form id ([#269](#269)) ([c6419b9](c6419b9)) * sticky sessions for keycloak in ha ([#281](#281)) ([5ccd557](5ccd557)) ### Miscellaneous * align mutation annotations ([#268](#268)) ([f18ad4d](f18ad4d)) * **deps:** update loki ([#209](#209)) ([03ca499](03ca499)) * **deps:** update pepr to v0.28.6 ([#254](#254)) ([54ef7de](54ef7de)) * **deps:** update zarf to v0.32.5 ([#243](#243)) ([ee93612](ee93612)) * typo fix in README.md ([#280](#280)) ([f9727e0](f9727e0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces SSO secret templating within the UDS Operator. This allows dynamic property bindings for the secret and custom file types such as nested JSON, YAML, etc.
Fixes #263