-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(config): Add configuration for adding javascript version. #7
Conversation
Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run. Closes karma-runner#1719
Please pull this fix to your own computer and perform |
Get it , I will do the tests soon. |
My tests are failing due to this error:
Seems to me that an object is null where it isn't supposed to be. Maybe you need to place an additional check or enforce object initialization. See here for full test output. Regards, Wesley van der Lee |
@wesleyvanderlee It seems that the test failures you are getting are not due to my change. Something is probably wrongly setup in your development environment. |
Tests are passed with the changes ! |
My test also failed and get the error like this:
|
Let's look into this when we are together. I might be able to help you fix your environment. |
This is still awaiting a proper review. Please review! |
I reconfigured my environment according to this site. Still get the same errors. Because everyone encounters those errors, I don't think it fully relies on the way our environment is set up. We should look together into this.. |
@wesleyvanderlee @liuyiran13 Why not create a VM with a Linux version on it and test it out? |
Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run. Closes karma-runner#1719
Did not seem to This one is now closed. |
Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run.
Closes karma-runner#1719