feat(config): Add configuration for adding javascript version. #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems I got those errors due to some wrong environment settings in Windows. After exhaustive search for the solution to this problem, I tested your work in a virtual machine, and I'm happy to announce that all tests pass! Furthermore the JavaScript tag does indeed work. Looks good ;). |
|
Since you have had the exact same errors as @liuyiran13 we can safely assume it was also a wrong environment setting. Also, @ludai0106 has confirmed that it works, so I created a PR for this! |
Moumi
force-pushed
the
feature-javascript-version-tag
branch
from
19a8ac7
to
bc7fd1d
Compare
Moumi
force-pushed
the
feature-javascript-version-tag
branch
from
bc7fd1d
to
c25ed00
Compare
Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run. Closes karma-runner#1719.
Moumi
force-pushed
the
feature-javascript-version-tag
branch
from
c25ed00
to
0239c75
Compare
|
finished |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the configuration to add a javascript version tag to the loaded scripts. Only applied when the Firefox browser is run.
Closes karma-runner#1719.