Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-660] Remove specific node image support #127

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

safronovD
Copy link
Contributor

@safronovD safronovD commented Apr 27, 2022

Purpose

Issue dell/csi-baremetal#660

After dell/csi-baremetal#656 it's not need to use same image and host kernel version

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

Testing details

Signed-off-by: safronovD <danil_safronov@dell.com>
Signed-off-by: safronovD <danil_safronov@dell.com>
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #127 (fffb7fd) into master (6152b2a) will decrease coverage by 3.39%.
The diff coverage is 16.66%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
- Coverage   52.43%   49.04%   -3.40%     
==========================================
  Files          10        8       -2     
  Lines         656      577      -79     
==========================================
- Hits          344      283      -61     
+ Misses        260      248      -12     
+ Partials       52       46       -6     
Flag Coverage Δ
unittests 49.04% <16.66%> (-3.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/node/node.go 54.76% <16.66%> (-14.29%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6152b2a...fffb7fd. Read the comment docs.

Signed-off-by: safronovD <danil_safronov@dell.com>
@safronovD safronovD changed the title deprecate specific node image version [ISSUE-660] Remove specific node image support Apr 29, 2022
@safronovD safronovD self-assigned this Apr 29, 2022
@safronovD safronovD added the enhancement New feature or request label Apr 29, 2022
@safronovD safronovD marked this pull request as ready for review April 29, 2022 14:28
@safronovD safronovD requested a review from a team as a code owner April 29, 2022 14:28
Copy link
Collaborator

@mishoyama mishoyama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makefile and documentation must also be updated.

@mitsaa mitsaa self-requested a review April 29, 2022 15:23
@safronovD safronovD marked this pull request as draft May 6, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants