Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-1018] Custom Storage Group Feature #180

Merged
merged 14 commits into from
Jun 27, 2023

Conversation

CraneShiEMC
Copy link
Collaborator

@CraneShiEMC CraneShiEMC commented May 5, 2023

Purpose

Issue dell/csi-baremetal#1018

Add the corresponding CRDs change to support the custom storage group feature.

PR checklist

  • Add link to the issue
  • Choose Project
  • Choose PR label
  • New unit tests added
  • Modified code has meaningful comments
  • All TODOs are linked with the issues
  • All comments are resolved

Testing

The updated and added CRDs has functioned well to support the custom storage group feature.

@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7aaddd9) 59.68% compared to head (ff4a1f1) 59.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #180   +/-   ##
=======================================
  Coverage   59.68%   59.68%           
=======================================
  Files          10       10           
  Lines        1156     1156           
=======================================
  Hits          690      690           
  Misses        399      399           
  Partials       67       67           
Flag Coverage Δ
unittests 59.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

CraneShiEMC and others added 5 commits May 6, 2023 23:15
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
@CraneShiEMC CraneShiEMC force-pushed the feature-storage-group-initial branch from 3a3311a to ee59fcc Compare June 11, 2023 06:57
Signed-off-by: Shi, Crane <crane.shi@emc.com>
@CraneShiEMC CraneShiEMC changed the title Feature storage group initial [ISSUE-1018] Custom Storage Group Feature Jun 20, 2023
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
@CraneShiEMC CraneShiEMC merged commit 6d12166 into master Jun 27, 2023
4 checks passed
@CraneShiEMC CraneShiEMC deleted the feature-storage-group-initial branch June 27, 2023 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants