[ISSUE-1018] Custom Storage Group Feature #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #997 +/- ##
==========================================
+ Coverage 72.90% 72.92% +0.01%
==========================================
Files 62 62
Lines 8250 8266 +16
==========================================
+ Hits 6015 6028 +13
- Misses 1978 1980 +2
- Partials 257 258 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: Shi, Crane <crane.shi@emc.com>
…ontroller" This reverts commit 7d57051. Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
libzhang
reviewed
Jun 20, 2023
libzhang
reviewed
Jun 20, 2023
libzhang
reviewed
Jun 20, 2023
libzhang
reviewed
Jun 20, 2023
libzhang
reviewed
Jun 20, 2023
| @@ -120,6 +121,7 @@ generate-baremetal-crds: install-controller-gen | |||
| controller-gen $(CRD_OPTIONS) paths=api/v1/drivecrd/drive_types.go paths=api/v1/drivecrd/groupversion_info.go output:crd:dir=$(CSI_CHART_CRDS_PATH) | |||
| controller-gen $(CRD_OPTIONS) paths=api/v1/lvgcrd/logicalvolumegroup_types.go paths=api/v1/lvgcrd/groupversion_info.go output:crd:dir=$(CSI_CHART_CRDS_PATH) | |||
| controller-gen $(CRD_OPTIONS) paths=api/v1/nodecrd/node_types.go paths=api/v1/nodecrd/groupversion_info.go output:crd:dir=$(CSI_CHART_CRDS_PATH) | |||
| controller-gen $(CRD_OPTIONS) paths=api/v1/storagegroupcrd/storagegroup_types.go paths=api/v1/storagegroupcrd/groupversion_info.go output:crd:dir=$(CSI_CHART_CRDS_PATH) | |||
|
|
|||
There was a problem hiding this comment.
also here need a PR on csi-baremetal-operator to add the new sg crd definition there.
There was a problem hiding this comment.
I've actually had a PR on csi-baremetal-operator for the corresponding storage group feature including the addition of sg crd, dell/csi-baremetal-operator#180... Sorry for forgetting to provide it for your review before...
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
CraneShiEMC
force-pushed
the
feature-storage-group-initial
branch
from
b953f24
to
cba700d
Compare
Signed-off-by: Shi, Crane <crane.shi@emc.com>
libzhang
approved these changes
Jun 25, 2023
Signed-off-by: Shi, Crane <crane.shi@emc.com>
yimingwangdell
approved these changes
Jun 26, 2023
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
yimingwangdell
approved these changes
Jun 26, 2023
yimingwangdell
approved these changes
Jun 26, 2023
CraneShiEMC
force-pushed
the
feature-storage-group-initial
branch
from
44cf129
to
4b2767d
Compare
Signed-off-by: Shi, Crane <crane.shi@emc.com>
CraneShiEMC
force-pushed
the
feature-storage-group-initial
branch
from
66baad5
to
2e544de
Compare
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Signed-off-by: Shi, Crane <crane.shi@emc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #1018
Support the custom storage group feature.
PR checklist
Testing
The custom storage group feature has functioned as expected in our various tests, including normal function and service procedure support.
Passed CSI custom ci: https://asd-ecs-jenkins.isus.emc.com/job/csi-custom-ci/1549/