Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-1018] Custom Storage Group Feature #997

Merged
merged 91 commits into from
Jun 27, 2023

Commits on Feb 27, 2023

  1. add StorageGroup property in proto message

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    e194e8d View commit details
    Browse the repository at this point in the history
  2. generate types.pb.go from types.proto

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    59ad30d View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2023

  1. make non-lvg volume creation consistent with storage group label

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    765ecc3 View commit details
    Browse the repository at this point in the history
  2. set storageGroup to volume CR

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 5, 2023
    Configuration menu
    Copy the full SHA
    55b0e23 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. support syncing storage group label to LVG CR if necessary

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    49f10e6 View commit details
    Browse the repository at this point in the history
  2. fix

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    4dde7f1 View commit details
    Browse the repository at this point in the history
  3. fix UT

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    e5a693a View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. remove setting storageGroup property in volume CR eventually

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    2bb28ef View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2023

  1. sync driveCR's storage-group label to AC

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    2fce327 View commit details
    Browse the repository at this point in the history
  2. fix UT

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    f0b3c83 View commit details
    Browse the repository at this point in the history
  3. fix UT

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Mar 20, 2023
    Configuration menu
    Copy the full SHA
    231f3ec View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50506da View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Configuration menu
    Copy the full SHA
    13a4df4 View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2023

  1. Configuration menu
    Copy the full SHA
    a19fa0e View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2023

  1. rename and extract the storagegroup label key as constants

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    78e986e View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. sync the storage-group label removal from drives to ACs

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    833a677 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2023

  1. Configuration menu
    Copy the full SHA
    09f9f3b View commit details
    Browse the repository at this point in the history
  2. remove sync storage-group label from drive to AC in capacitycontroller

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 5, 2023
    Configuration menu
    Copy the full SHA
    7d57051 View commit details
    Browse the repository at this point in the history
  3. Revert "remove sync storage-group label from drive to AC in capacityc…

    …ontroller"
    
    This reverts commit 7d57051.
    
    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 5, 2023
    Configuration menu
    Copy the full SHA
    c7225e4 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2023

  1. Add StorageGroup Schema Definition and generated files

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 6, 2023
    Configuration menu
    Copy the full SHA
    7abaaf1 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2023

  1. refine StorageGroup definition

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 7, 2023
    Configuration menu
    Copy the full SHA
    dd2911c View commit details
    Browse the repository at this point in the history
  2. Add storagegroup controller

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 7, 2023
    Configuration menu
    Copy the full SHA
    946359e View commit details
    Browse the repository at this point in the history

Commits on May 8, 2023

  1. Add storagegroup crd to scheme

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 8, 2023
    Configuration menu
    Copy the full SHA
    237a282 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. handling of storagegroup creation

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 14, 2023
    Configuration menu
    Copy the full SHA
    dc427b3 View commit details
    Browse the repository at this point in the history
  2. remove sync storage-group label from drive to AC in capacitycontroller

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 14, 2023
    Configuration menu
    Copy the full SHA
    668f002 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    16d96be View commit details
    Browse the repository at this point in the history

Commits on May 15, 2023

  1. fix

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 15, 2023
    Configuration menu
    Copy the full SHA
    bc2a375 View commit details
    Browse the repository at this point in the history
  2. add debug log

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 15, 2023
    Configuration menu
    Copy the full SHA
    3d75309 View commit details
    Browse the repository at this point in the history
  3. support storage-group deletion

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 15, 2023
    Configuration menu
    Copy the full SHA
    086146e View commit details
    Browse the repository at this point in the history

Commits on May 18, 2023

  1. Configuration menu
    Copy the full SHA
    c67ede0 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2023

  1. Handle invalidField and make MatchFields ANDed

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 19, 2023
    Configuration menu
    Copy the full SHA
    92b82f6 View commit details
    Browse the repository at this point in the history
  2. support NumberDrivesPerNode in DriveSelector

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 19, 2023
    Configuration menu
    Copy the full SHA
    0a17dbf View commit details
    Browse the repository at this point in the history

Commits on May 20, 2023

  1. fix & add log for noDriveSelected and invalidField

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 20, 2023
    Configuration menu
    Copy the full SHA
    87f1db9 View commit details
    Browse the repository at this point in the history
  2. refine log

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 20, 2023
    Configuration menu
    Copy the full SHA
    7abce20 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. fix issue in noDriveSelected and numberDrivesPerNode support

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 21, 2023
    Configuration menu
    Copy the full SHA
    0f72b5b View commit details
    Browse the repository at this point in the history

Commits on May 22, 2023

  1. refine log

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 22, 2023
    Configuration menu
    Copy the full SHA
    f966767 View commit details
    Browse the repository at this point in the history
  2. fix matchFields issue on bool type

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 22, 2023
    Configuration menu
    Copy the full SHA
    25d33cc View commit details
    Browse the repository at this point in the history
  3. fix the issue that drive with non-lvg volume may be selected

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 22, 2023
    Configuration menu
    Copy the full SHA
    52f933f View commit details
    Browse the repository at this point in the history

Commits on May 25, 2023

  1. Configuration menu
    Copy the full SHA
    3448a18 View commit details
    Browse the repository at this point in the history
  2. fix golint

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 25, 2023
    Configuration menu
    Copy the full SHA
    1802e7e View commit details
    Browse the repository at this point in the history
  3. fix golint

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 25, 2023
    Configuration menu
    Copy the full SHA
    7f35687 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2023

  1. refine handleStorageGroupCreation

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 27, 2023
    Configuration menu
    Copy the full SHA
    eb41273 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2023

  1. refine handleStorageGroupCreation

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 28, 2023
    Configuration menu
    Copy the full SHA
    b36a14d View commit details
    Browse the repository at this point in the history

Commits on May 29, 2023

  1. refine to fix golint error

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 29, 2023
    Configuration menu
    Copy the full SHA
    7d61b3f View commit details
    Browse the repository at this point in the history
  2. fix golint

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 29, 2023
    Configuration menu
    Copy the full SHA
    03049a9 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2023

  1. refine log

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 30, 2023
    Configuration menu
    Copy the full SHA
    baf7afb View commit details
    Browse the repository at this point in the history
  2. Change storagegroup print column

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 30, 2023
    Configuration menu
    Copy the full SHA
    bb78b37 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    520144d View commit details
    Browse the repository at this point in the history
  4. support manual storage-group labeling on drive again

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 30, 2023
    Configuration menu
    Copy the full SHA
    3636d47 View commit details
    Browse the repository at this point in the history
  5. Merge branch 'feature-storage-group-initial' of https://github.com/de…

    …ll/csi-baremetal into feature-storage-group-initial
    
    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 30, 2023
    Configuration menu
    Copy the full SHA
    566f49e View commit details
    Browse the repository at this point in the history

Commits on May 31, 2023

  1. only watch storagegroup delete event in storagegroup controller

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 31, 2023
    Configuration menu
    Copy the full SHA
    f035c0d View commit details
    Browse the repository at this point in the history
  2. Refactor func to add/rm sg label and enhance manual sg labeling

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed May 31, 2023
    Configuration menu
    Copy the full SHA
    381ff9c View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2023

  1. support to get ac for drive with lvg in drive sg label sync

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 4, 2023
    Configuration menu
    Copy the full SHA
    80a56c8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    09f27be View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2023

  1. now also include drive del event for storagegroup controller

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    9d10619 View commit details
    Browse the repository at this point in the history
  2. fix log error

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    4c558f9 View commit details
    Browse the repository at this point in the history
  3. fix that no del event of sg is caught

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    82597ba View commit details
    Browse the repository at this point in the history
  4. refine log & add initial draft of func syncDriveOnAllStorageGroups

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    1c10de2 View commit details
    Browse the repository at this point in the history
  5. support simple status tracking of storagegroup

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    d02dc02 View commit details
    Browse the repository at this point in the history
  6. add support of storage group label sync on new drive creation

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    8364271 View commit details
    Browse the repository at this point in the history
  7. fix lint error

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    a3bdbfd View commit details
    Browse the repository at this point in the history
  8. fix lint error

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    ee055c8 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    d6b0c18 View commit details
    Browse the repository at this point in the history
  2. service procedure only supports storage group whose numDrivesPerNode …

    …is 0
    
    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 6, 2023
    Configuration menu
    Copy the full SHA
    9d1f096 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2023

  1. fix sg nil annotation panic error

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    bd75ce6 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2023

  1. service procedure support of storage group whose numDrivesPerNode>0

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    5565239 View commit details
    Browse the repository at this point in the history
  2. fix go lint error

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    caa6679 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. fix issue in reconcile of sg with numberDrivesPerNode>0

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    aa1ec1d View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2023

  1. refine logic for reconcile of sg with numDrivesPerNode>0

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    ab28f47 View commit details
    Browse the repository at this point in the history
  2. sg label restore on drive selected by sg with numDrviesPerNode>0

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    0a6452d View commit details
    Browse the repository at this point in the history
  3. refine the logic to sync drive label on sg with numDrivesPerNode>0

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    d96429f View commit details
    Browse the repository at this point in the history
  4. Revert syncing storage group label to LVG CR if necessary

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    1dd0b14 View commit details
    Browse the repository at this point in the history
  5. fix error in log

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    17fa105 View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. add more log for adding sg label to drive

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    046da2c View commit details
    Browse the repository at this point in the history
  2. refine log

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    1634127 View commit details
    Browse the repository at this point in the history
  3. refine code comment and increase UT coverage

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    3e9accd View commit details
    Browse the repository at this point in the history
  4. try increase UT coverage

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    fcaf2f6 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2023

  1. Configuration menu
    Copy the full SHA
    077d75e View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. resolve review comments

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9eebed9 View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. refine storagegroupcontroller updateEventFilter & nil labels case handle

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    0ce6eee View commit details
    Browse the repository at this point in the history
  2. try fix golint

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    ad569d9 View commit details
    Browse the repository at this point in the history
  3. try to fix golint

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    b2d9c09 View commit details
    Browse the repository at this point in the history
  4. fix devkit base image tag to 15.4 to resolve devkit image build failure

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    cba700d View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. nil map can still work for map entry read

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f9e8688 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. refine error handling and error log

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    d4463f0 View commit details
    Browse the repository at this point in the history
  2. add comments to main function

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    daf9fc3 View commit details
    Browse the repository at this point in the history
  3. refine error messages for labeling and label removal in sg handling

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    d861003 View commit details
    Browse the repository at this point in the history
  4. removal some deprecated bool flags

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    6c9ec1f View commit details
    Browse the repository at this point in the history
  5. sync storage group label to LVG CR if necessary

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    2e544de View commit details
    Browse the repository at this point in the history
  6. refine sg ctrl's drive update event predicate to include drive removal

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8341362 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. still only focus on drive sg label update event

    Signed-off-by: Shi, Crane <crane.shi@emc.com>
    CraneShiEMC committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    04f731e View commit details
    Browse the repository at this point in the history