[ISSUE-656] Support SLES 15 SP3 in CSI #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aber4Nod
force-pushed
the
feature-issue-656-replace-parted
branch
from
2f6ba01
to
c96a2ee
Compare
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
- Coverage 63.88% 63.84% -0.05%
==========================================
Files 61 61
Lines 6191 6184 -7
==========================================
- Hits 3955 3948 -7
Misses 2025 2025
Partials 211 211
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Aber4Nod
force-pushed
the
feature-issue-656-replace-parted
branch
from
ba70393
to
f4218eb
Compare
safronovD
reviewed
Dec 15, 2021
Aber4Nod
force-pushed
the
feature-issue-656-replace-parted
branch
from
f4218eb
to
4dff6d6
Compare
rkiselenko
approved these changes
Dec 16, 2021
mishoyama
reviewed
Dec 16, 2021
pkg/node/Dockerfile.build
Outdated
| @@ -5,4 +5,14 @@ ADD health_probe health_probe | |||
| # Remove bash packet to get rid of related CVEs | |||
| RUN apt update --no-install-recommends -y -q; apt remove --no-install-recommends -y --allow-remove-essential -q bash; apt install --no-install-recommends -y -q util-linux parted xfsprogs lvm2 gdisk strace udev net-tools | |||
|
|
|||
|
|
|||
| # Don't rely on udevd, it isn't available in some combinations of host/guest kernels. | |||
There was a problem hiding this comment.
isn't available not precise term here. not compatible due to poll/epoll APIs sounds better. Please add md doc with your finding and post refence here
There was a problem hiding this comment.
Added docs, removed changes to Dockerfile due to after repeated tests the issue with lvm was not reproduced
yurkov-anton
approved these changes
Dec 16, 2021
Aber4Nod
force-pushed
the
feature-issue-656-replace-parted
branch
2 times, most recently
from
2f4b30a
to
859a789
Compare
mitsaa
approved these changes
Dec 16, 2021
mishoyama
approved these changes
Dec 16, 2021
added 13 commits
December 16, 2021 15:47
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
added 2 commits
December 16, 2021 15:47
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Signed-off-by: Nikita Mikhnenko <nikita_mikhnenko@dell.com>
Aber4Nod
force-pushed
the
feature-issue-656-replace-parted
branch
from
859a789
to
c61b693
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Resolves #656
Replace parted with sgdisk
Replace partprobe with blockdev
Turn off lvm synchronization with udev
PR checklist
Testing
Provide test details