Skip to content

Conversation

@sidharth30060
Copy link
Collaborator

@sidharth30060 sidharth30060 commented Jan 22, 2025

Description

Updating Cert-CSI Version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1710

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions
Copy link

github-actions bot commented Jan 22, 2025

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit eff77ae. ± Comparison against base commit 9fd0344.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to take care of the v1,v2,v3 in main otherwise it will be chain break

Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidharth30060 Please ensure on the "v1" folder has change related to cert-csi version.

Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Cert-CSI version fix,, can you please ensure "changes" made in the Release branch is present in the "V1" folder of Main?

Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rajkumar-palani rajkumar-palani merged commit 5144383 into main Jan 28, 2025
7 checks passed
@rajkumar-palani rajkumar-palani deleted the cert-csi_version-fix branch January 28, 2025 06:09
@sidharth30060 sidharth30060 mentioned this pull request Jan 29, 2025
5 tasks
sidharth30060 added a commit that referenced this pull request Feb 1, 2025
@sidharth30060 sidharth30060 mentioned this pull request Feb 3, 2025
5 tasks
rajkumar-palani pushed a commit that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants