Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CERT-CSI Version Fix #1427

Merged
merged 4 commits into from
Jan 28, 2025
Merged

CERT-CSI Version Fix #1427

merged 4 commits into from
Jan 28, 2025

Conversation

sidharth30060
Copy link
Collaborator

@sidharth30060 sidharth30060 commented Jan 22, 2025 •
edited
Loading

Description

Updating Cert-CSI Version

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1710

Checklist:

  • Have you run a grammar and spell checks against your submission?
  • Have you tested the changes locally?
  • Have you tested whether the hyperlinks are working properly?
  • Did you add the examples wherever applicable?
  • Have you added high-resolution images?

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 22, 2025 •
edited
Loading

Test Results

77 tests  ±0   77 ✅ ±0   3s ⏱️ ±0s
 3 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit eff77ae. ± Comparison against base commit 9fd0344.

♻️ This comment has been updated with latest results.

@francis-nijay francis-nijay marked this pull request as ready for review January 22, 2025 18:25
prablr79
prablr79 reviewed Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@prablr79 prablr79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to take care of the v1,v2,v3 in main otherwise it will be chain break

rajkumar-palani
rajkumar-palani approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sidharth30060 Please ensure on the "v1" folder has change related to cert-csi version.

rajkumar-palani
rajkumar-palani requested changes Jan 24, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For Cert-CSI version fix,, can you please ensure "changes" made in the Release branch is present in the "V1" folder of Main?

rajkumar-palani
rajkumar-palani approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@rajkumar-palani rajkumar-palani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rajkumar-palani rajkumar-palani merged commit 5144383 into main Jan 28, 2025
7 checks passed
@rajkumar-palani rajkumar-palani deleted the cert-csi_version-fix branch January 28, 2025 06:09
@sidharth30060 sidharth30060 mentioned this pull request Jan 29, 2025
Closed
5 tasks
sidharth30060 added a commit that referenced this pull request Feb 1, 2025
@sidharth30060
CERT-CSI Version Fix (#1427)
e264b21
@sidharth30060 sidharth30060 mentioned this pull request Feb 3, 2025
Merged
5 tasks
rajkumar-palani pushed a commit that referenced this pull request Feb 4, 2025
@sidharth30060
CERT-CSI Version Fix (#1427) (#1440)
ff24733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkumar-palani rajkumar-palani rajkumar-palani approved these changes

@prablr79 prablr79 prablr79 approved these changes

@donatwork donatwork donatwork approved these changes

@gallacher gallacher Awaiting requested review from gallacher gallacher is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@AronAtDell AronAtDell Awaiting requested review from AronAtDell AronAtDell is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@rsedlock1958 rsedlock1958 Awaiting requested review from rsedlock1958 rsedlock1958 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sidharth30060 @donatwork @prablr79 @rajkumar-palani