Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the e2e tests #829

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Fix the e2e tests #829

merged 2 commits into from
Dec 20, 2024

Conversation

meggm
Copy link
Contributor

@meggm meggm commented Dec 17, 2024 •
edited by mgandharva
Loading

Description

  • Fix the E2E tests with making changes to the imagePullPolicy for the nightly image as Always
  • Updated replica count to 2.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1648

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • E2E "Install PowerMax Driver(Sidecar)"
  • E2E "Install PowerScale Driver(Standalone)"

meggm added 2 commits December 17, 2024 18:28
@meggm
Fix the e2e tests
57be3ba 
Signed-off-by: meghana_gm <meghana.gm@dell.com>
@meggm
Fix the e2e tests
b5c73bf 
Signed-off-by: meghana_gm <meghana.gm@dell.com>
@mgandharva mgandharva marked this pull request as ready for review December 18, 2024 13:16
gallacher
gallacher requested changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@gallacher gallacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please describe what is being fixed and why. Where is the GitHub issue link?

@mgandharva
Copy link
Contributor

mgandharva commented Dec 19, 2024 •
edited
Loading

Please describe what is being fixed and why. Where is the GitHub issue link?

Github issue updated, please review. @gallacher

@mgandharva mgandharva requested a review from gallacher December 20, 2024 10:01
@mgandharva mgandharva merged commit 91165ff into main Dec 20, 2024
7 checks passed
@mgandharva mgandharva deleted the fix-e2e-tests branch December 20, 2024 12:24
@OliverChen557 OliverChen557 mentioned this pull request Jan 7, 2025
Merged
11 tasks
This was referenced Jan 7, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarishH-DELL HarishH-DELL HarishH-DELL approved these changes

@Deepak-Ghivari Deepak-Ghivari Deepak-Ghivari approved these changes

@gallacher gallacher gallacher approved these changes

@harishp8889 harishp8889 harishp8889 approved these changes

@abhi16394 abhi16394 Awaiting requested review from abhi16394 abhi16394 is a code owner

@mbasha-dell mbasha-dell Awaiting requested review from mbasha-dell mbasha-dell is a code owner

@alikdell alikdell Awaiting requested review from alikdell alikdell is a code owner

@bharathsreekanth bharathsreekanth Awaiting requested review from bharathsreekanth bharathsreekanth is a code owner

@chimanjain chimanjain Awaiting requested review from chimanjain chimanjain is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@gilltaran gilltaran Awaiting requested review from gilltaran gilltaran is a code owner

@JacobGros JacobGros Awaiting requested review from JacobGros JacobGros is a code owner

@jooseppi-luna jooseppi-luna Awaiting requested review from jooseppi-luna jooseppi-luna is a code owner

@karthikk92 karthikk92 Awaiting requested review from karthikk92 karthikk92 is a code owner

@kumarkgosa kumarkgosa Awaiting requested review from kumarkgosa kumarkgosa is a code owner

@bandak2 bandak2 Awaiting requested review from bandak2 bandak2 is a code owner

@mgandharva mgandharva Awaiting requested review from mgandharva mgandharva is a code owner

@mjsdell mjsdell Awaiting requested review from mjsdell mjsdell is a code owner

@nitesh3108 nitesh3108 Awaiting requested review from nitesh3108 nitesh3108 is a code owner

@Prabhu-Dell Prabhu-Dell Awaiting requested review from Prabhu-Dell Prabhu-Dell is a code owner

@rajendraindukuri rajendraindukuri Awaiting requested review from rajendraindukuri rajendraindukuri is a code owner

@rajkumar-palani rajkumar-palani Awaiting requested review from rajkumar-palani rajkumar-palani is a code owner

@shefali-malhotra shefali-malhotra Awaiting requested review from shefali-malhotra shefali-malhotra is a code owner

@panigs7 panigs7 Awaiting requested review from panigs7 panigs7 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@atye atye Awaiting requested review from atye atye is a code owner

@sharmilarama sharmilarama Awaiting requested review from sharmilarama sharmilarama is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@meggm @mgandharva @harishp8889 @gallacher @Deepak-Ghivari @HarishH-DELL