Fix Operator E2E on PowerScale

[enestvedto-dell]

Description

Fixed a small regression from the PR #829. The file powerscale_alt_vals_2_values.csv expects parameter value of 1 for 'Replicas'. However, the reality is that in file storage_csm_powerscale_alt_vals_2.yaml, the value is set to 2. The policies in the yaml file are ideal, so a change to the csv was made.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1648

Checklist:

• I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
• I have verified that new and existing unit tests pass locally with my changes
• I have not allowed coverage numbers to degenerate
• I have maintained at least 90% code coverage
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• I have maintained backward compatibility
• I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

• Successful run of the related test scenario. Log snippet of the test scenario:

  �[1mSTEP:�[0m Starting: Install PowerScale Driver with second alternate sample file  �[38;5;243m@ 01/07/25 10:52:53.277�[0m
  �[1mSTEP:�[0m Returning false at end �[38;5;243m@ 01/07/25 10:52:53.277�[0m
  �[1mSTEP:�[0m      Executing  Given an environment with k8s or openshift, and CSM operator installed �[38;5;243m@ 01/07/25 10:52:53.277�[0m
  �[1mSTEP:�[0m      Executing  Create storageclass with name [op-e2e-isilon] and template [testfiles/powerscale-templates/powerscale-storageclass-template.yaml] for [pscale] �[38;5;243m@ 01/07/25 10:52:53.283�[0m
  �[1mSTEP:�[0m      Executing  Set up secret with template [testfiles/powerscale-templates/powerscale-secret-template.yaml] name [csm-creds] in namespace [dell] for [pscale] �[38;5;243m@ 01/07/25 10:52:53.947�[0m
  �[1mSTEP:�[0m      Executing  Apply custom resource [1] �[38;5;243m@ 01/07/25 10:52:54.555�[0m
  I0107 10:52:54.555565 182755 builder.go:121] Running '/usr/bin/kubectl --namespace=dell apply --validate=true -f -'
  I0107 10:52:54.757802 182755 builder.go:146] stderr: ""
  I0107 10:52:54.757938 182755 builder.go:147] stdout: "containerstoragemodule.storage.dell.com/powerscale created\n"
  �[1mSTEP:�[0m      Executing  Validate custom resource [1] �[38;5;243m@ 01/07/25 10:52:54.757�[0m
  �[1mSTEP:�[0m      Executing  Validate [powerscale] driver from CR [1] is installed �[38;5;243m@ 01/07/25 10:53:14.779�[0m
  �[1mSTEP:�[0m      Executing  Run custom test �[38;5;243m@ 01/07/25 10:53:34.8�[0m
  I0107 10:53:34.800126 182755 util.go:645] Running /bin/bash [check_parameters.sh testfiles/powerscale_alt_vals_2_values.csv dell powerscale]
1 occurences of F S Group Policy with value None found in csm
1 occurences of Replicas with value 2 found in csm
1 occurences of X_CSI_VERBOSE with value 2 found in controller
1 occurences of X_CSI_ISI_VOLUME_PATH_PERMISSIONS with value 757 found in controller
1 occurences of X_CSI_ISI_SKIP_CERTIFICATE_VALIDATION with value true found in controller
1 occurences of Node-Selectors with value none found in controller
1 occurences of Tolerations with value none found in controller
  �[1mSTEP:�[0m      Executing  Enable forceRemoveDriver on CR [1] �[38;5;243m@ 01/07/25 10:53:35.763�[0m
  �[1mSTEP:�[0m      Executing  Delete custom resource [1] �[38;5;243m@ 01/07/25 10:53:35.788�[0m
  �[1mSTEP:�[0m      Executing  Validate [powerscale] driver from CR [1] is not installed �[38;5;243m@ 01/07/25 10:53:35.809�[0m
  �[1mSTEP:�[0m      Executing  Restore template [testfiles/powerscale-templates/powerscale-secret-template.yaml] for [pscale] �[38;5;243m@ 01/07/25 10:53:55.816�[0m
  �[1mSTEP:�[0m      Executing  Restore template [testfiles/powerscale-templates/powerscale-storageclass-template.yaml] for [pscale] �[38;5;243m@ 01/07/25 10:53:55.896�[0m
  �[1mSTEP:�[0m Ending: Install PowerScale Driver with second alternate sample file

• Successful full run of Operator E2E on PowerScale without modules (7 test scenarios in total). Log snippet of the related test scenario:

�[1mSTEP:�[0m Starting: Install PowerScale Driver with second alternate sample file  �[38;5;243m@ 01/07/25 10:27:13.593�[0m
  �[1mSTEP:�[0m Returning false at end �[38;5;243m@ 01/07/25 10:27:13.593�[0m
  �[1mSTEP:�[0m      Executing  Given an environment with k8s or openshift, and CSM operator installed �[38;5;243m@ 01/07/25 10:27:13.593�[0m
  �[1mSTEP:�[0m      Executing  Create storageclass with name [op-e2e-isilon] and template [testfiles/powerscale-templates/powerscale-storageclass-template.yaml] for [pscale] �[38;5;243m@ 01/07/25 10:27:13.598�[0m
  �[1mSTEP:�[0m      Executing  Set up secret with template [testfiles/powerscale-templates/powerscale-secret-template.yaml] name [csm-creds] in namespace [dell] for [pscale] �[38;5;243m@ 01/07/25 10:27:14.216�[0m
  �[1mSTEP:�[0m      Executing  Apply custom resource [1] �[38;5;243m@ 01/07/25 10:27:14.83�[0m
  I0107 10:27:14.830313 173625 builder.go:121] Running '/usr/bin/kubectl --namespace=dell apply --validate=true -f -'
  I0107 10:27:15.081535 173625 builder.go:146] stderr: ""
  I0107 10:27:15.081708 173625 builder.go:147] stdout: "containerstoragemodule.storage.dell.com/powerscale created\n"
  �[1mSTEP:�[0m      Executing  Validate custom resource [1] �[38;5;243m@ 01/07/25 10:27:15.081�[0m
  �[1mSTEP:�[0m      Executing  Validate [powerscale] driver from CR [1] is installed �[38;5;243m@ 01/07/25 10:27:35.093�[0m
  �[1mSTEP:�[0m      Executing  Run custom test �[38;5;243m@ 01/07/25 10:27:55.113�[0m
  I0107 10:27:55.113862 173625 util.go:645] Running /bin/bash [check_parameters.sh testfiles/powerscale_alt_vals_2_values.csv dell powerscale]
1 occurences of F S Group Policy with value None found in csm
1 occurences of Replicas with value 2 found in csm
1 occurences of X_CSI_VERBOSE with value 2 found in controller
1 occurences of X_CSI_ISI_VOLUME_PATH_PERMISSIONS with value 757 found in controller
1 occurences of X_CSI_ISI_SKIP_CERTIFICATE_VALIDATION with value true found in controller
1 occurences of Node-Selectors with value none found in controller
1 occurences of Tolerations with value none found in controller
  �[1mSTEP:�[0m      Executing  Enable forceRemoveDriver on CR [1] �[38;5;243m@ 01/07/25 10:27:56.077�[0m
  �[1mSTEP:�[0m      Executing  Delete custom resource [1] �[38;5;243m@ 01/07/25 10:27:56.097�[0m
  �[1mSTEP:�[0m      Executing  Validate [powerscale] driver from CR [1] is not installed �[38;5;243m@ 01/07/25 10:27:56.115�[0m
  �[1mSTEP:�[0m      Executing  Restore template [testfiles/powerscale-templates/powerscale-secret-template.yaml] for [pscale] �[38;5;243m@ 01/07/25 10:28:16.133�[0m
  �[1mSTEP:�[0m      Executing  Restore template [testfiles/powerscale-templates/powerscale-storageclass-template.yaml] for [pscale] �[38;5;243m@ 01/07/25 10:28:16.22�[0m
  �[1mSTEP:�[0m Ending: Install PowerScale Driver with second alternate sample file

[gallacher]

Why is this open and dell/csm#1648 closed?

[enestvedto-dell]

Why is this open and dell/csm#1648 closed?

Changes from that github issue were the reason this test regressed and needed a fix. Also, this PR from this morning is very similar and did the same and was approved so I followed: #845

[gallacher]

Why is this open and dell/csm#1648 closed?

Changes from that github issue were the reason this test regressed and needed a fix. Also, this PR from this morning is very similar and did the same and was approved so I followed: #845

Can you please evaluate other platforms this change needs to be made for. Are there others?

[enestvedto-dell]

Why is this open and dell/csm#1648 closed?

Changes from that github issue were the reason this test regressed and needed a fix. Also, this PR from this morning is very similar and did the same and was approved so I followed: #845

Can you please evaluate other platforms this change needs to be made for. Are there others?

Note: We are running OperatorE2E tests excluding modules right now.
Yes, we have already identified and fixed an issue in PowerFlex. PowerMax is passing. This change fixes PowerScale. Lastly, PowerStore/Unity currently have a defect opened for a failing EphemeralVolumeSuite blocking following cases from executing.