Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifiable values consistent across drivers #830

Merged
merged 4 commits into from
Dec 23, 2024

Conversation

rishabhatdell
Copy link
Contributor

@rishabhatdell rishabhatdell commented Dec 18, 2024

Description

  • This PR made modifiable values in values.yaml consistent across drivers
  • Fixed CVE-2024-45338

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
dell/csm#1647

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility
  • I have executed the relevant end-to-end test scenarios

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Installed Powerflex driver with new yaml
  • Built Image
  • Ran e2e for a driver
    image

Sorry, something went wrong.

shanmydell
shanmydell previously approved these changes Dec 18, 2024
Copy link
Contributor

@mgandharva mgandharva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rishabhatdell, Don't changes in E2E sample files be required?

suryagupta4
suryagupta4 previously approved these changes Dec 18, 2024
@rishabhatdell rishabhatdell dismissed stale reviews from suryagupta4 and shanmydell via 0ce34ae December 19, 2024 08:33
Copy link
Contributor

@gilltaran gilltaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rishabhatdell rishabhatdell merged commit d825739 into main Dec 23, 2024
7 checks passed
@rishabhatdell rishabhatdell deleted the consistency_all_driver branch December 23, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants