-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifiable values consistent across drivers #830
Merged
Merged
+145
−163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabhatdell
changed the title
made values.yaml consistent across drivers
Modifiable values consistent across drivers
Dec 18, 2024
rishabhatdell
requested review from
abhi16394,
mbasha-dell,
alikdell,
bharathsreekanth,
chimanjain,
coulof,
Deepak-Ghivari,
gallacher,
gilltaran,
harishp8889,
HarishH-DELL,
JacobGros,
jooseppi-luna,
karthikk92,
kumarkgosa,
bandak2,
meggm,
mgandharva,
mjsdell,
nitesh3108,
Prabhu-Dell,
rajendraindukuri,
rajkumar-palani,
shefali-malhotra,
panigs7,
tdawe and
shaynafinocchiaro
as code owners
December 18, 2024 11:37
rishabhatdell
requested review from
atye,
sharmilarama and
shanmydell
as code owners
December 18, 2024 11:37
shanmydell
previously approved these changes
Dec 18, 2024
mgandharva
reviewed
Dec 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabhatdell, Don't changes in E2E sample files be required?
suryagupta4
previously approved these changes
Dec 18, 2024
adarsh-dell
reviewed
Dec 18, 2024
adarsh-dell
reviewed
Dec 18, 2024
rishabhatdell
dismissed stale reviews from suryagupta4 and shanmydell
via
December 19, 2024 08:33
0ce34ae
donatwork
reviewed
Dec 19, 2024
suryagupta4
approved these changes
Dec 19, 2024
AkshaySainiDell
approved these changes
Dec 20, 2024
gilltaran
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration