-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add auth v2 e2e tests using PowerMax mount credentials #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
falfaroc
requested changes
Feb 12, 2025
operatorconfig/moduleconfig/csireverseproxy/v2.10.0/container.yaml
Outdated
Show resolved
Hide resolved
tests/e2e/testfiles/powermax-templates/powermax-use-secret-auth-template.yaml
Show resolved
Hide resolved
e6d958f
to
02983b8
Compare
ba3f6b0
to
492afb1
Compare
falfaroc
approved these changes
Feb 27, 2025
* Add new powermax and reverseproxy cr * Add dynamic secret mounting for reverseproxy By providing the secret name, we assume that we are using the new secret configuration for PowerMax. This propagates the information and sets the useSecret to true in the reverseProxy. Also, it automatically creates the volume and mount for the reverseProxy. * Dynamically mount either the configMap or secret for PowerMax * Remove unused code * Add unit tests for PowerMax secret * Fix deployment of reverse proxy sidecar with secret * Update use secret environment variable * Update unit tests * Update reverse proxy controller yaml * Update powermax secret variable processing * Add PowerMax secret e2e test * Update steps def for e2e tests * gofumpt all files * Address validation errors * Cleanup variable setting for PowerMax secret * Address validation errors * Address PR comments and add e2e test * Update copyrights
* Dynamically mount config params in the reverse proxy Also, dynamically adds the reverse proxy port to the config params * Dynamically mount config params in the reverse proxy for non-sidecar * Clean up dynamically adding parameters and add unit tests * Address lint errors * Address gosec errors * Cleanup duplicate code and remove not needed sections * Address lint errors
* Dynamically mount secret or config map on Powermax observability * Remove unused code * Add PowerMax observability mount credentials unit tests * Add PowerMax observability mount credentials e2e test * Ensure that minimal manifest with mount credentials works Adds e2e test to cover this scenario * Generalize min version for Mount Credential variable
26a885c
to
1425349
Compare
tdawe
approved these changes
Feb 27, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add E2E tests that installs the Powermax driver using mount credentials and enables Authorization v2.
GitHub Issues
List the GitHub issues impacted by this PR:
Checklist:
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration