Skip to content

Improving UT coverage #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 55 commits into from
Closed

Improving UT coverage #73

wants to merge 55 commits into from

Conversation

@samihan-dell
Copy link
Contributor

@samihan-dell samihan-dell commented Jan 2, 2025 •
edited
Loading

Description

Increasing Unit test code coverage

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
https://github.com/dell/csm/issues/1707

Results when ran unit tests locally:
image

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

mbasha-dell and others added 30 commits December 4, 2024 20:59
@mbasha-dell
added test case for ParseLuns
f4447c8
@mbasha-dell
added test for GetPowerPathDevices
274718c
@samihan-dell
Merge branch 'main' of https://github.com/dell/gobrick into pub/ut-co…
ba80e23 
…verage
@samihan-dell
test: Increased UT code coverage to 86.2% for pkg/scsi
cfe4014
@samihan-dell
test: Increased UT code coverage
452559b
@samihan-dell
test: Increased coverage of gobrick package to 50.6%
6d71250
@samihan-dell
test: Increased coverage of gobrick package to 50.6%
830abd5
@samihan-dell
test: Added few UTs
5aad100
@samihan-dell
test: Updated few UTs
ce65e45
@niranjan-n1
increased the pkg/gobrick code coverage to 54.5%
d491e69
@niranjan-n1
fixed lint issue
bf45de5
@samihan-dell
test: Added few test in nvme.go file
09a7ed8
@samihan-dell
test: Fixed tests now rdm.go UTs are passing
49b4c36
@samihan-dell
test: increased UT coverage by almost 3%
ba9b3b6
@samihan-dell
test: Refactored nvme.go UTs
54d0d6b
@samihan-dell
test: Added UTs for nvme ConnectVolume increased coverage by almost 10%
365ba71
@samihan-dell
test: Added commented testcase but its failing
b14d40c
@samihan-dell
test: Increased UT coverage to 71.1% Added UTs for nvme.go file
ded17f6
@samihan-dell
test: Fixed failing UTs for tryNVMeConnect in nvme.go
c3e80d8
@niranjan-n1
Merge branch 'main' into pub/ut-coverage
26fc05b
@samihan-dell
test: Added UT for tryEnableManualISCSISessionMGMT
9cf0e33
@samihan-dell
test: Upadted UTs for connectPowerpathDevice
ab5ba30
@samihan-dell
test: Added few test in iscsi_test.go file
38f0342
@samihan-dell
test: added unit test in nvme_test.go
893968b
@samihan-dell
fix: fixing linting issue
49efb14
@samihan-dell
test: Added Unt test for nvme.go
0074df8
@samihan-dell
test: Added Unt test for nvme.go
8977fdf
@samihan-dell
test: Added mocks for NVMe struct
df1070f
@samihan-dell
test: Added Unit test for nvme.go
446e7c1
@samihan-dell
test: Added Unit test for ConnectVolume in nvme.go
52625bb
@samihan-dell samihan-dell self-assigned this Feb 28, 2025
@samihan-dell samihan-dell marked this pull request as ready for review February 28, 2025 19:09
@shaynafinocchiaro
Copy link
Collaborator

shaynafinocchiaro commented Feb 28, 2025

Please sign commits.

@satyakonduri
Copy link
Contributor

satyakonduri commented Mar 3, 2025

Addressing this in #86 PR.

@satyakonduri satyakonduri deleted the pub/ut-coverage branch March 3, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alikdell alikdell alikdell approved these changes

@kumarp20 kumarp20 Awaiting requested review from kumarp20

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004

@francis-nijay francis-nijay Awaiting requested review from francis-nijay

@harishp8889 harishp8889 Awaiting requested review from harishp8889

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@tdawe tdawe Awaiting requested review from tdawe tdawe is a code owner

@coulof coulof Awaiting requested review from coulof

@shaynafinocchiaro shaynafinocchiaro Awaiting requested review from shaynafinocchiaro shaynafinocchiaro is a code owner

@xuluna xuluna Awaiting requested review from xuluna

@alankar-verma alankar-verma Awaiting requested review from alankar-verma

@chaganti-rajitha chaganti-rajitha Awaiting requested review from chaganti-rajitha

@niranjan-n1 niranjan-n1 Awaiting requested review from niranjan-n1

@khareRajshree khareRajshree Awaiting requested review from khareRajshree

@satyakonduri satyakonduri Awaiting requested review from satyakonduri

+1 more reviewer

@atye atye atye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@samihan-dell samihan-dell

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@samihan-dell @shaynafinocchiaro @satyakonduri @atye @alikdell @mbasha-dell @niranjan-n1 @chaganti-rajitha