Skip to content

Commit

Permalink
Merge pull request #36 from dell/upgrade-gopkg
Browse files Browse the repository at this point in the history
Fixing linting and format
  • Loading branch information
alikdell authored Feb 26, 2024
2 parents f892779 + cf57fbd commit e4146a1
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 14 deletions.
8 changes: 5 additions & 3 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
# be requested for review when someone opens a pull request.
# order is alphabetical for easier maintenance.
#

# Aaron Tye (atye)
# Alik Saring (alikdell)
# Boya Murthy (boyamurthy)
# Bahubali Jain (bpjain2004)
# Florian Coulombel (coulof)
Expand All @@ -22,7 +23,8 @@
# Santhosh shekarappa (santhoshhs10)
# Yamunadevi Shanmugam (shanmydell)
# Sushma T S (tssushma)

# Shayna Finocchiaro (shaynafinocchiaro)
# Luna Xu (xuluna)

# for all files:
* @boyamurthy @bpjain2004 @coulof @delldubey @francis-nijay @harishp8889 @hoppea2 @kumarp20 @nidtara @prablr79 @tdawe @santhoshhs10 @shanmydell @tssushma
* @boyamurthy @bpjain2004 @coulof @delldubey @francis-nijay @harishp8889 @hoppea2 @kumarp20 @nidtara @prablr79 @tdawe @santhoshhs10 @shanmydell @tssushma @alikdell @atye @shaynafinocchiaro @xuluna
6 changes: 3 additions & 3 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Run the formatter, linter, and vetter
uses: dell/common-github-actions/go-code-formatter-linter-vetter@main
with:
Expand All @@ -20,15 +20,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Run Go Security
uses: securego/gosec@master
malware_security_scan:
name: Malware Scanner
runs-on: ubuntu-latest
steps:
- name: Checkout the code
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Run malware scan
uses: dell/common-github-actions/malware-scanner@main
with:
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/linters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ jobs:
name: golangci-lint
runs-on: ubuntu-latest
steps:
- uses: actions/setup-go@v4
- uses: actions/setup-go@v5
with:
go-version: "1.20"
go-version: "1.22"
cache: false
- name: Checkout the code
uses: actions/checkout@v3.2.0
uses: actions/checkout@v4.1.0
- name: Vendor packages
run: |
go mod vendor
- name: golangci-lint
uses: golangci/golangci-lint-action@v3
uses: golangci/golangci-lint-action@v4
with:
version: v1.53
version: latest
skip-cache: true
6 changes: 3 additions & 3 deletions gonvme_mock.go
Original file line number Diff line number Diff line change
Expand Up @@ -205,13 +205,13 @@ func (nvme *MockNVMe) ListNVMeNamespaceID(_ []DevicePathAndNamespace) (map[Devic
for idx := 0; idx < int(count); idx++ {
init := fmt.Sprintf("%05d", idx)
var currentPathAndNamespace DevicePathAndNamespace
var namespaceIds []string
var namespaceIDs []string

currentPathAndNamespace.DevicePath = "/dev/nvme0n" + init
currentPathAndNamespace.Namespace = init

namespaceIds = append(namespaceIds, "0x"+init)
mockedNamespaceIDs[currentPathAndNamespace] = namespaceIds
namespaceIDs = append(namespaceIDs, "0x"+init)
mockedNamespaceIDs[currentPathAndNamespace] = namespaceIDs
}
return mockedNamespaceIDs, nil
}
Expand Down

0 comments on commit e4146a1

Please sign in to comment.