Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing linting and format #36

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fixing linting and format #36

merged 1 commit into from
Feb 26, 2024

Conversation

alikdell
Copy link
Contributor

@alikdell alikdell commented Feb 26, 2024 •
edited
Loading

Description

Fixing linting and format.

GitHub Issues

List the GitHub issues impacted by this PR:

GitHub Issue #
#dell/csm#926

Checklist:

  • I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • Backward compatibility is not broken

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@alikdell alikdell merged commit e4146a1 into main Feb 26, 2024
4 checks passed
@alikdell alikdell deleted the upgrade-gopkg branch February 26, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KerryKovacevic KerryKovacevic KerryKovacevic approved these changes

@atye atye atye approved these changes

@tdawe tdawe tdawe approved these changes

@boyamurthy boyamurthy Awaiting requested review from boyamurthy boyamurthy is a code owner

@bpjain2004 bpjain2004 Awaiting requested review from bpjain2004 bpjain2004 is a code owner

@coulof coulof Awaiting requested review from coulof coulof is a code owner

@delldubey delldubey Awaiting requested review from delldubey delldubey is a code owner

@francis-nijay francis-nijay Awaiting requested review from francis-nijay francis-nijay is a code owner

@harishp8889 harishp8889 Awaiting requested review from harishp8889 harishp8889 is a code owner

@hoppea2 hoppea2 Awaiting requested review from hoppea2 hoppea2 is a code owner

@kumarp20 kumarp20 Awaiting requested review from kumarp20 kumarp20 is a code owner

@nidtara nidtara Awaiting requested review from nidtara nidtara is a code owner

@prablr79 prablr79 Awaiting requested review from prablr79 prablr79 is a code owner

@santhoshhs10 santhoshhs10 Awaiting requested review from santhoshhs10 santhoshhs10 is a code owner

@shanmydell shanmydell Awaiting requested review from shanmydell shanmydell is a code owner

@tssushma tssushma Awaiting requested review from tssushma tssushma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alikdell @tdawe @atye @KerryKovacevic