fix: column parsing to include nested columns and enclosing char #2737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtrawinski
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
gtrawinski
changed the title
ion-elgreco
reviewed
Aug 8, 2024
ion-elgreco
reviewed
Aug 14, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…0.18.x chore: removed unused imports fix: PR feedback for stats field parsing
alexwilcoxson-rel
force-pushed
the
backtick_structfield_support
branch
from
84c1ff3
to
49dab7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added column parsing to include nested columns and `` enclosing to adopt 0.18.x
Addressing issue
#2572
https://github.com/delta-io/delta/blob/4b102d34a2ce881b2a851b4c6cfbf2ab3ab5534f/spark/src/main/scala/org/apache/spark/sql/delta/DeltaConfig.scala#L549-L561
Changes:
Added:
extract_enclosed_string - is a utility function to remove enclosing characters from a string.
get_stats_field - is a function to retrieve a field from a schema, handling nested field names and removing enclosing backticks.