Fix checkpoint and timestamp bugs #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosyp
force-pushed
the
writer-map-support
branch
from
e684571
to
46a5729
Compare
xianwill
force-pushed
the
checkpoint_bug
branch
from
f8f077a
to
162d013
Compare
|
@xianwill I had to edit your PR because you were picking a bug that is fixed in recent main. |
|
It's a PR to |
…point_bug # Conflicts: # Cargo.lock # python/Cargo.toml # rust/Cargo.toml # rust/src/delta_arrow.rs
mosyp
approved these changes
Aug 12, 2021
mosyp
added a commit
that referenced
this pull request
Sep 14, 2021
* Bump arrow deps and bring map support to schema * Fix datafustion deps * Fix checkpoint and timestamp bugs (#351) * post merge fixes * Add tests for new checkpoint API * Post merge from main * Reverse integrate main to writer-map-support * post merge fixes * cargo fmt * Fix checkpoint compatibility for remove fields (#427) * Add datafusion PR link Co-authored-by: Christian Williams <christianw@scribd.com> Co-authored-by: xianwill <christianwilliams79@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes several blocking issues related to checkpoint data and schema correctness.
One especially important note is that I'm switching from nanoseconds to microseconds for the default arrow timestamp unit. Neither actually works well for read scenarios because the parquet timestamp could be one of various types (delta-io/delta#643), but for writes, microseconds definitely looks like the best bet for broad support and good precision.
Note: I'm merging this to the writer-map-support branch rather than main because the required arrow and parquet crate refs aren't ref'ed by datafusion yet.
Additional note: this also picks up @mosyp's fix to the fs backend that was merged to main in #376