Allow filesystem backend put_obj to overwrite existing #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianwill
approved these changes
Aug 11, 2021
mosyp
commented
Aug 12, 2021
| Ok(_) => Ok(()), | ||
| Err(e) => { | ||
| // If rename failed, clean up the temp file. | ||
| self.delete_obj(tmp_path).await?; | ||
| //self.delete_obj(tmp_path).await?; |
|
@mosyp I think we have a race condition in this change. The file could be deleted or created between the path exists check and the atomic rename call. Could you check my comment at #367 (comment) to see if what I said there makes sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow up of #367.
put_objhas to follow the semantic of replace existing which was violated with recent changes. There's atomic swap supported by additional flags ofrename2but it only works if both files are present. As a workaround I'm adding a files_exists() call to determine which rename to call.