cleanup base activities #2508
Merged
cleanup base activities #2508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To test the changes in this pull request, install this apk: |
r10s
force-pushed
the
fix-multi-device-activity-stack
branch
from
e7f9d6d
to
a886b68
Compare
|
To test the changes in this pull request, install this apk: |
r10s
force-pushed
the
fix-multi-device-activity-stack
branch
from
a886b68
to
1045c55
Compare
|
To test the changes in this pull request, install this apk: |
r10s
force-pushed
the
fix-multi-device-activity-stack
branch
2 times, most recently
from
1045c55
to
de940dd
Compare
|
To test the changes in this pull request, install this apk: |
adbenitez
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr removes superfluous overwrites from
PassphraseRequiredActionBarActivityand moves theinitFragment()functions fromPassphraseRequiredActionBarActivityto its parent,BaseTitleBarActivity.this makes
initFragment()accessible from all activities.successor of #2493
targets #2493 (comment) and some cleanup for finally fixing #2507