add multi-device-setup #2493
Merged
add multi-device-setup #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r10s
force-pushed
the
multi-device-qr
branch
4 times, most recently
from
368f21e
to
5ecc8a5
Compare
18 tasks
r10s
force-pushed
the
multi-device-qr
branch
2 times, most recently
from
32b2f45
to
5b55422
Compare
Merged
r10s
force-pushed
the
multi-device-qr
branch
7 times, most recently
from
3a3c111
to
2ef7382
Compare
r10s
force-pushed
the
multi-device-qr
branch
7 times, most recently
from
fedf317
to
1270e9a
Compare
25 tasks
|
hm, maybe better to put 1-3 directly below each other |
was thinking exactly that while looking the picture |
this seems slightly catchier as "Add Another Device"
and has less "A" esp. in "Add as Another Device" :)
also at least translation to german seems nicer ("Zweitgerät"),
most ppl will use max. two devices, but even if more,
that should still be fine.
this was also the first intuition also by other devs in their mockups,
so we'll give it a try.
let's give that a try - "Account" is also widely used, so that seems to make some sense. even if not 100% fitting, it seems better than introducing the new term "Collection".
Hocuri
reviewed
Mar 23, 2023
|
To test the changes in this pull request, install this apk: |
Hocuri
reviewed
Mar 23, 2023
Co-authored-by: Hocuri <hocuri@gmx.de>
Co-authored-by: Hocuri <hocuri@gmx.de>
Co-authored-by: Hocuri <hocuri@gmx.de>
Co-authored-by: Hocuri <hocuri@gmx.de>
Co-authored-by: Hocuri <hocuri@gmx.de>
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
Hocuri
approved these changes
Mar 24, 2023
|
To test the changes in this pull request, install this apk: |
|
To test the changes in this pull request, install this apk: |
|
merged that in already, i'll fix the open known bug in a subsequent pr |
This was referenced Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires deltachat/deltachat-core-rust#4007 to be checked out
counterpart of deltachat/deltachat-ios#1822
sender:
receiver: