Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add multi-device-setup #1822

Merged
merged 34 commits into from
Mar 31, 2023
Merged

add multi-device-setup #1822

merged 34 commits into from
Mar 31, 2023

Conversation

r10s
Copy link
Member

@r10s r10s commented Mar 7, 2023

requires deltachat/deltachat-core-rust#4007 to be checked out

counterpart of deltachat/deltachat-android#2493

replaces #1649

Screenshot 2023-03-30 at 12 55 07Screenshot 2023-03-30 at 13 01 57

the layout is not perfect, but this is what we could achieve with the limited resources :)

todo:

  • wrapper
  • basic UI
  • show progress, hide QR code once scanned (this is also nice feedback)
  • consider calling triggerLocalNetworkPrivacyAlert() on receiving, EDIT: in contrast to [WIP] Iroh share UI #1649 there are currently no crashes when the alert is shown "in interrupted core", however, it still seems advantageous to have a bit more control, if things shift around
  • consider calling triggerLocalNetworkPrivacyAlert() on sending - we did not do this that time in [WIP] Iroh share UI #1649 - is it needed? one should try out of the alert pops up at all (make sure, to be on an installation where the alert was not triggered before) - EDIT: yes, it makes sense for the same reasons on sending
  • use "Cancel" instead of back button to make also visually clear, things are aborted when leaving
  • keep transfer screens on
  • add a warning when one wants to leave the transfer screen during transfer
  • add dedicated "Add as Second Device" button to welcome screen
  • if wording is settled on android, pull it from there
  • add "experimental" hint to all places
  • improve layout, at least of sender (for a MVP, the receiver is good enough)
  • add a confirmation dialog before showing the qr code
  • add menu with "troubleshooting" and "copy to clipboard" to sender
  • fix: scanning from the in-app-qr-code scanner brings you to the welcome screen, but without action

optional for 1.36:

  • sender-layout for landscape
  • add progress bar instead of showing percentages (percentages may be out of sync with receiver)
  • consider checking system secret before sending transfer, link, however, for 1.36, this seems optional

counterpart of deltachat/deltachat-android#2493

@r10s r10s force-pushed the multi-device-qr branch 4 times, most recently from ab504a4 to fd7c67b Compare March 16, 2023 16:19
@r10s r10s mentioned this pull request Mar 18, 2023
@r10s r10s force-pushed the multi-device-qr branch 2 times, most recently from 9a62ab5 to 471e5ce Compare March 18, 2023 20:23
@r10s r10s mentioned this pull request Mar 19, 2023
@r10s r10s force-pushed the multi-device-qr branch 3 times, most recently from c964088 to 3a3ba25 Compare March 19, 2023 16:05
@r10s r10s force-pushed the multi-device-qr branch 8 times, most recently from 01adf36 to 88b983d Compare March 25, 2023 23:18
@r10s r10s merged commit a062a3f into master Mar 31, 2023
@r10s r10s deleted the multi-device-qr branch March 31, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant