Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt to new "instant onboarding" UX workflow #3015

Merged
merged 15 commits into from
May 6, 2024
Merged

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented Apr 30, 2024

close #2996

  • use new intro image in welcome screen
  • change buttons in welcome screen
  • implement sign-in path a.k.a "I already have a login" button
  • implement sign-up path a.k.a "let's get started!" button for default instance
  • add "explore more options" and "scan QR" options to InstantOnboardingActivity
  • implement "scan QR" button in InstantOnboardingActivity
  • process "DCACCOUNT:" scheme URIs with InstantOnboardingActivity instead of WelcomeActivity
  • clean-up, remove unused code in WelcomeActivity etc

Screenshot 2024-05-05 at 11 32 33   Screenshot 2024-05-05 at 11 35 20   Screenshot 2024-05-05 at 11 35 36

counterpart of deltachat/deltachat-desktop#3773

Copy link

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

github-actions bot commented May 2, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

github-actions bot commented May 3, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Copy link

github-actions bot commented May 3, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez marked this pull request as ready for review May 3, 2024 19:50
@adbenitez adbenitez requested a review from r10s May 3, 2024 19:51
Copy link

github-actions bot commented May 3, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@r10s
Copy link
Member

r10s commented May 3, 2024

did a functionality test of all but scanning, things work fine and look good. did not test QR codes yet, and also did not look at the code yet.

one minor comment for now:

Screenshot 2024-05-03 at 22 23 59

these linebreaks in the lower buttons do not look nice and seem superfluous. otherwise, the left/right buttons are not bad, worth a try

the buttons could also be tuned down further, so using the color&font of the subtitle "Set a name..." (i know this is not visible as a button at the first glance then, but that is how things are nowadays - and in this case it is okay; the more the other things stand out)

@adbenitez
Copy link
Member Author

these linebreaks in the lower buttons do not look nice and seem superfluous. otherwise, the left/right buttons are not bad, worth a try

it doesn't do the line break in all phones it depends on screen size, that was my struggle into making that work in a way that if for some language the text is too long it would wrap around instead of pushing the second button out of view, it turned out to be harder than what I expected

@r10s
Copy link
Member

r10s commented May 3, 2024

no blocker, was just wondering. maybe jt can be fixed by a simple xml flag adapting button width to content (instead of making both button 50% each)

@r10s
Copy link
Member

r10s commented May 5, 2024

/me now also checked quite some QR and "Explore Other Option" flows ... all nicely so far :) and i never created so many accounts is so few time ;)

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, code also lgtm, just some minors, no blockers.

i think, we should get that in soon to do a beta release, to get it tested by far more ppl

res/layout/instant_onboarding_activity.xml Show resolved Hide resolved
res/layout/login_options_view.xml Show resolved Hide resolved
Copy link

github-actions bot commented May 6, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

Co-authored-by: bjoern <r10s@b44t.com>
Copy link

github-actions bot commented May 6, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

@adbenitez adbenitez merged commit 81b7df0 into main May 6, 2024
2 checks passed
@adbenitez adbenitez deleted the adb/issue-2996 branch May 6, 2024 12:32
@adbenitez adbenitez self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

New "Instant Onboarding" UX flow to create accounts
2 participants