-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adapt to new "instant onboarding" UX workflow #3015
Conversation
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
To test the changes in this pull request, install this apk: |
did a functionality test of all but scanning, things work fine and look good. did not test QR codes yet, and also did not look at the code yet. one minor comment for now: these linebreaks in the lower buttons do not look nice and seem superfluous. otherwise, the left/right buttons are not bad, worth a try the buttons could also be tuned down further, so using the color&font of the subtitle "Set a name..." (i know this is not visible as a button at the first glance then, but that is how things are nowadays - and in this case it is okay; the more the other things stand out) |
it doesn't do the line break in all phones it depends on screen size, that was my struggle into making that work in a way that if for some language the text is too long it would wrap around instead of pushing the second button out of view, it turned out to be harder than what I expected |
no blocker, was just wondering. maybe jt can be fixed by a simple xml flag adapting button width to content (instead of making both button 50% each) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, code also lgtm, just some minors, no blockers.
i think, we should get that in soon to do a beta release, to get it tested by far more ppl
Co-authored-by: bjoern <r10s@b44t.com>
Co-authored-by: bjoern <r10s@b44t.com>
Co-authored-by: bjoern <r10s@b44t.com>
To test the changes in this pull request, install this apk: |
Co-authored-by: bjoern <r10s@b44t.com>
To test the changes in this pull request, install this apk: |
close #2996
counterpart of deltachat/deltachat-desktop#3773