Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs and some code cleanup #3023

Merged
merged 5 commits into from
May 7, 2024
Merged

fix bugs and some code cleanup #3023

merged 5 commits into from
May 7, 2024

Conversation

adbenitez
Copy link
Member

@adbenitez adbenitez commented May 6, 2024 •
edited
Loading

  • fix: when scanning "add as second device" QR code from chatlist's QR button open WelcomeActivity, not InstantOnboardingActivity
  • fix: InstantOnboardingActivity: go back to chatlist when back button is pressed and we don't come from WelcomeActivity
  • remove unused code in WelcomeActivity

followup of #3015

@adbenitez adbenitez requested a review from r10s May 6, 2024 17:27
@adbenitez adbenitez changed the title fix bug and some code cleanup fix bugs and some code cleanup May 6, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

To test the changes in this pull request, install this apk:
📦 app-preview.apk

r10s
r10s approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, also tested a bit.

more testing will show more bugs, so, let's get it in and get one step further to an 1.45 beta :)

@adbenitez adbenitez merged commit 8df2749 into main May 7, 2024
2 checks passed
@adbenitez adbenitez deleted the adb/improve-welcome-activity branch May 7, 2024 16:53
@adbenitez adbenitez self-assigned this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r10s r10s r10s approved these changes

Assignees

@adbenitez adbenitez

Labels
None yet
Projects
No open projects
1.46.0 - Instant Onboarding - May Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adbenitez @r10s