Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip requestSingleInstanceLock on mac appstore builds (mas), because it made it unable to start the app on older macOS devices. #3946

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

Simon-Laux
Copy link
Member

closes #3938

…e it made it unable to start the app on older macOS devices.

closes #3938
Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code/logic lgtm, could not test, however

@Simon-Laux
Copy link
Member Author

I think the release will be testing for this one, sure there might be other ways to try it before with special provisioning certificates from apple, but I'm too busy with other issues to investigate those.

@Simon-Laux Simon-Laux merged commit 97af86c into main Jun 17, 2024
2 of 6 checks passed
@Simon-Laux Simon-Laux deleted the simon/i3938-skip-requestSingleInstanceLock-on-mas branch June 17, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apple Store package not starting on MacOS Silicon; DMG works fine
2 participants