Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip requestSingleInstanceLock on mac appstore builds (mas), because it made it unable to start the app on older macOS devices. #3946

Merged
merged 2 commits into from
Jun 17, 2024
Merged

skip requestSingleInstanceLock on mac appstore builds (mas), because it made it unable to start the app on older macOS devices. #3946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8466dfd
skip `requestSingleInstanceLock` on mac appstore builds (mas), becaus…
Simon-Laux Jun 17, 2024
972a9b5
Add pr number to changelog
Simon-Laux Jun 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## [Unreleased][unreleased]

### Fixed
- skip `requestSingleInstanceLock` on mac appstore builds (mas), because it made it unable to start the app on older macOS devices. #3946

<a id="1_46_0"></a>

## [v1.46.0] - 2024-06-10
Expand Down
5 changes: 4 additions & 1 deletion src/main/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,10 @@ protocol.registerSchemesAsPrivileged([
const app = rawApp as ExtendedAppMainProcess
app.rc = rc

if (!app.requestSingleInstanceLock()) {
// requestSingleInstanceLock always returns false on mas (mac app store) builds
// due to electron issue https://github.com/electron/electron/issues/35540
// dc-desktop issue: https://github.com/deltachat/deltachat-desktop/issues/3938
if (!process.mas && !app.requestSingleInstanceLock()) {
/* ignore-console-log */
console.error('Only one instance allowed. Quitting.')
app.quit()
Expand Down
Loading