improvement: improve a11y #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicodh
requested changes
Oct 11, 2024
There was a problem hiding this comment.
I reviewed and rebased this PR. Good improvements!
Everything looks fine, only he type error needs to be fixed:
Error: packages/frontend check:types: src/components/AccountListSidebar/AccountItem.tsx(199,7): error TS2322: Type 'RefObject<HTMLDivElement>' is not assignable to type
but the ref is passed through, so it refers to a Div Element and on a Button Element....
6 tasks
Keyboard-focusable
Not adding one for the "Settings" button because I'm lazy + it's already available in the "File" menu as an "accelerator".
|
Fixed the error, added a changelog entry and rebased. |
nicodh
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan on working on accessibility (a11y) more, but generally this can be merged at any point.
Recommended review commit by commit.