Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix borderless drag issues and add debug overlay to better test issues about draging area #4300

Merged
merged 18 commits into from
Nov 28, 2024

Conversation

Simon-Laux
Copy link
Member

@Simon-Laux Simon-Laux commented Nov 1, 2024

Bildschirmfoto 2024-11-01 um 01 59 15 add `exp.showDragAreas()` development api to make drag areas visible.

red is drag, green is no-drag.
How to use: go into electron dev tools, execute exp.showDragAreas() to toggle the overlay which makes drag areas visible.
This is a useful tool to make the issues with it more tangible.

Fix some of the bugs:

  • make dialogs no-drag
  • add input and button elements in case we missed cases, they should always be clickable
  • make background image on "no account selected"- and welcome screen a drag area
  • don't make dialog headers drag areas
  • remove unused z-index css code from context menu
  • make context menu not dragable

todo? or make new issue:

  • Fullscreen media view -> where can I drag that?

closes #4018
closes #3926

@Simon-Laux Simon-Laux added bug Something isn't working OS: Mac Related to MacOS labels Nov 1, 2024
@Simon-Laux Simon-Laux requested review from nicodh and r10s November 1, 2024 01:02
Copy link
Collaborator

@WofWca WofWca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked that the added DragRegionOverlay is not relevant in production. But it would also be nice to not include its code in the production build.

As to essence of this MR: I haven't checked it thoroughly, because I'm not on Mac.
But in general not so many lines have been changed.

Copy link
Member

@r10s r10s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an impressive layout, thanks for moving forward on that issue; in general, beside fullscreen, that seems to work on quick testing :)

Fullscreen media view -> where can I drag that?

i would expect that to work in the upper area of the screen, where normally the title bar is - similar to welcome screen

i cannot say much to the code, however :)

Copy link
Contributor

@nicodh nicodh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fullscreen media issue can be solved in a later fix imho

@r10s
Copy link
Member

r10s commented Nov 25, 2024

Fullscreen media issue can be solved in a later fix imho

agree, but we should file an issue for that then

@Simon-Laux
Copy link
Member Author

Simon-Laux commented Nov 26, 2024

So todo to merge this pr:

  • add changelog entry
  • file issue for the remaining issue with the full screen media view.

@nicodh nicodh merged commit 5e07d5e into main Nov 28, 2024
10 checks passed
@nicodh nicodh deleted the simon/i4018-fix-borderless-drag-regions branch November 28, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OS: Mac Related to MacOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mac: unclear window dragging areas message details window bugs
4 participants