Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to hyperdrive 5 #1259

Merged
merged 3 commits into from
Jan 17, 2024
Merged

update to hyperdrive 5 #1259

merged 3 commits into from
Jan 17, 2024

Conversation

dpaiton
Copy link
Member

@dpaiton dpaiton commented Jan 17, 2024

No description provided.

@dpaiton dpaiton force-pushed the dpaiton/update-hyperdrive-5 branch from d318abe to 4306bba Compare January 17, 2024 21:06
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (64747c1) 80.99% compared to head (4306bba) 80.88%.

Files Patch % Lines
...ethpy/ethpy/hyperdrive/interface/_mock_contract.py 50.00% 1 Missing ⚠️
...ethpy/ethpy/hyperdrive/interface/read_interface.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1259      +/-   ##
==========================================
- Coverage   80.99%   80.88%   -0.12%     
==========================================
  Files          94       94              
  Lines        5384     5388       +4     
==========================================
- Hits         4361     4358       -3     
- Misses       1023     1030       +7     
Flag Coverage Δ
unittests 80.88% <60.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sentilesdal sentilesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dpaiton dpaiton merged commit 18054c9 into main Jan 17, 2024
3 of 4 checks passed
@dpaiton dpaiton deleted the dpaiton/update-hyperdrive-5 branch January 17, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants