add support for wrapped hyperdrive tokens #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables support for hyperdrive instances with rebasing tokens since yearn is unable to support rebasing tokens
|
Leaving this in draft since I'm getting some very confusing approval reverts, will investigate more tomorrow |
mcclurejt
force-pushed
the
mcclurejt/feat/wrapped-tokens
branch
from
7f56771 to
2724d8e
Compare
mcclurejt
force-pushed
the
mcclurejt/feat/wrapped-tokens
branch
from
2724d8e to
abcc575
Compare
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
reviewed
Dec 14, 2024
jalextowle
approved these changes
Dec 14, 2024
Co-authored-by: Alex Towle <jalextowle@gmail.com>
|
@jalextowle I created a separate PR for the conversion issues we were seeing (will be needed for tests to pass on this one) Happy to do whatever you think is best with it |
Some values received from hyperdrive are denominated in base tokens. These must be converted to vault shares token denominated values when `asBase==true || isWrapped==true` in the strategy
| uint256 aliceShares = depositWrapped(alice, depositAmount); | ||
|
|
||
| // Alice should have non-zero share amounts. | ||
| assertGt(aliceShares, 0); |
There was a problem hiding this comment.
Since you're starting with a specific fork block number in VaultTest, you should be able to assert on an exact number consistently here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support for hyperdrive instances with rebasing tokens since yearn is unable to support rebasing tokens.