correctly convert base token denominated values from hyperdrive #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
reviewed
Dec 15, 2024
| @@ -502,8 +502,9 @@ contract EverlongStrategy is BaseStrategy { | |||
| // Hyperdrive's minimum transaction amount. | |||
| if ( | |||
| totalPositionValue > | |||
| (_targetOutput - output + _poolConfig.minimumTransactionAmount) | |||
| .mulUp(ONE + partialPositionClosureBuffer) | |||
| (_targetOutput - output + _minimumTransactionAmount()).mulUp( | |||
There was a problem hiding this comment.
This looks right to me. I scrutinized this because I wanted to be sure that we weren't potentially comparing a bond amount to shares. This looks right since it's shares > share, but I do want to point out that if the LHS was in bonds, we would want to use _poolConfig.minimumTransactionAmount rather than _minimumTransactionAmount. Seems like this is being done correctly in the PR though, so this is just a note.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 15, 2024
* add support for wrapped hyperdrive tokens This enables support for hyperdrive instances with rebasing tokens since yearn is unable to support rebasing tokens * fixes and redeem part of test * test fix * fix issues with LPMath library revert on getPoolInfo * cleanup * responding to feedback from @jalextowle * responding to feedback from @jalextowle * convert "hyperdrive token" language to `execution token` language * Update contracts/EverlongStrategy.sol Co-authored-by: Alex Towle <jalextowle@gmail.com> * correctly convert base token values from hyperdrive (#38) Some values received from hyperdrive are denominated in base tokens. These must be converted to vault shares token denominated values when `asBase==true || isWrapped==true` in the strategy --------- Co-authored-by: Alex Towle <jalextowle@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some values received from hyperdrive are denominated in base tokens.
These must be converted to vault shares token denominated values when
asBase==true || isWrapped==truein the strategy