Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router refactor #22

Merged
merged 9 commits into from
Dec 9, 2020
Merged

Router refactor #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e567e23
Wrap App in Router
demaceo Dec 7, 2020
cc669f8
Add Loader component
demaceo Dec 7, 2020
28276b1
Add Home component
demaceo Dec 7, 2020
0d71084
Reposition FeatureMovies above NavBar
demaceo Dec 8, 2020
f53798e
Add scss to NavBar
demaceo Dec 8, 2020
18bc151
Refact movie selection and error handling
demaceo Dec 9, 2020
8a22c20
Remove handleClick
demaceo Dec 9, 2020
28a5183
Remove handleClick and cleaned up code
demaceo Dec 9, 2020
a66a6b5
Error handling for SelectedMovie
demaceo Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintcache
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
[{"/Users/calebcyphers/turing/3module/rantom/src/index.js":"1","/Users/calebcyphers/turing/3module/rantom/src/App.js":"2","/Users/calebcyphers/turing/3module/rantom/src/Components/NavBar/NavBar.js":"3","/Users/calebcyphers/turing/3module/rantom/src/Components/Catalogue/Catalogue.js":"4","/Users/calebcyphers/turing/3module/rantom/src/Components/SelectedMovie/SelectedMovie.js":"5","/Users/calebcyphers/turing/3module/rantom/src/Components/MovieCard/MovieCard.js":"6","/Users/calebcyphers/turing/3module/rantom/src/Components/FeaturedMovies/FeaturedMovies.js":"7","/Users/calebcyphers/turing/3module/rantom/src/apiCalls.js":"8"},{"size":198,"mtime":1606950547962,"results":"9","hashOfConfig":"10"},{"size":2993,"mtime":1607129950229,"results":"11","hashOfConfig":"10"},{"size":537,"mtime":1607129647368,"results":"12","hashOfConfig":"10"},{"size":622,"mtime":1607113607212,"results":"13","hashOfConfig":"10"},{"size":724,"mtime":1607128891056,"results":"14","hashOfConfig":"10"},{"size":767,"mtime":1607129668835,"results":"15","hashOfConfig":"10"},{"size":1700,"mtime":1607129686203,"results":"16","hashOfConfig":"10"},{"size":314,"mtime":1607113587153,"results":"17","hashOfConfig":"10"},{"filePath":"18","messages":"19","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"20"},"1sgm5h0",{"filePath":"21","messages":"22","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"23","messages":"24","errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"25","messages":"26","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"27","messages":"28","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"29","messages":"30","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"31","messages":"32","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},{"filePath":"33","messages":"34","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0},"/Users/calebcyphers/turing/3module/rantom/src/index.js",[],["35","36"],"/Users/calebcyphers/turing/3module/rantom/src/App.js",[],"/Users/calebcyphers/turing/3module/rantom/src/Components/NavBar/NavBar.js",["37"],"/Users/calebcyphers/turing/3module/rantom/src/Components/Catalogue/Catalogue.js",[],"/Users/calebcyphers/turing/3module/rantom/src/Components/SelectedMovie/SelectedMovie.js",[],"/Users/calebcyphers/turing/3module/rantom/src/Components/MovieCard/MovieCard.js",[],"/Users/calebcyphers/turing/3module/rantom/src/Components/FeaturedMovies/FeaturedMovies.js",[],"/Users/calebcyphers/turing/3module/rantom/src/apiCalls.js",[],{"ruleId":"38","replacedBy":"39"},{"ruleId":"40","replacedBy":"41"},{"ruleId":"42","severity":1,"message":"43","line":2,"column":23,"nodeType":"44","messageId":"45","endLine":2,"endColumn":34},"no-native-reassign",["46"],"no-negated-in-lhs",["47"],"no-unused-vars","'NavDropdown' is defined but never used.","Identifier","unusedVar","no-global-assign","no-unsafe-negation"]
[{"/Users/demaceovincent/rantom/src/index.js":"1","/Users/demaceovincent/rantom/src/App.js":"2","/Users/demaceovincent/rantom/src/apiCalls.js":"3","/Users/demaceovincent/rantom/src/Components/NavBar/NavBar.js":"4","/Users/demaceovincent/rantom/src/Components/SelectedMovie/SelectedMovie.js":"5","/Users/demaceovincent/rantom/src/Components/Catalogue/Catalogue.js":"6","/Users/demaceovincent/rantom/src/Components/FeaturedMovies/FeaturedMovies.js":"7","/Users/demaceovincent/rantom/src/Components/MovieCard/MovieCard.js":"8","/Users/demaceovincent/rantom/src/Components/Loader/Loader.js":"9","/Users/demaceovincent/rantom/src/Components/Home/Home.js":"10"},{"size":287,"mtime":1607468546248,"results":"11","hashOfConfig":"12"},{"size":3105,"mtime":1607549738909,"results":"13","hashOfConfig":"12"},{"size":314,"mtime":1607193982018,"results":"14","hashOfConfig":"12"},{"size":342,"mtime":1607548012042,"results":"15","hashOfConfig":"12"},{"size":798,"mtime":1607549186207,"results":"16","hashOfConfig":"12"},{"size":721,"mtime":1607547956371,"results":"17","hashOfConfig":"12"},{"size":2516,"mtime":1607477425309,"results":"18","hashOfConfig":"12"},{"size":895,"mtime":1607547961480,"results":"19","hashOfConfig":"12"},{"size":877,"mtime":1607381016593,"results":"20","hashOfConfig":"12"},{"size":370,"mtime":1607547950865,"results":"21","hashOfConfig":"12"},{"filePath":"22","messages":"23","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"24"},"14dzppr",{"filePath":"25","messages":"26","errorCount":0,"warningCount":4,"fixableErrorCount":0,"fixableWarningCount":0,"source":null},{"filePath":"27","messages":"28","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"24"},{"filePath":"29","messages":"30","errorCount":0,"warningCount":3,"fixableErrorCount":0,"fixableWarningCount":0,"source":"31","usedDeprecatedRules":"24"},{"filePath":"32","messages":"33","errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":"34","usedDeprecatedRules":"24"},{"filePath":"35","messages":"36","errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":"37","usedDeprecatedRules":"24"},{"filePath":"38","messages":"39","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"24"},{"filePath":"40","messages":"41","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"24"},{"filePath":"42","messages":"43","errorCount":0,"warningCount":0,"fixableErrorCount":0,"fixableWarningCount":0,"usedDeprecatedRules":"24"},{"filePath":"44","messages":"45","errorCount":0,"warningCount":1,"fixableErrorCount":0,"fixableWarningCount":0,"source":"46","usedDeprecatedRules":"24"},"/Users/demaceovincent/rantom/src/index.js",[],["47","48"],"/Users/demaceovincent/rantom/src/App.js",["49","50","51","52"],"/Users/demaceovincent/rantom/src/apiCalls.js",[],"/Users/demaceovincent/rantom/src/Components/NavBar/NavBar.js",["53","54","55"],"import React from \"react\";\nimport { Navbar, Nav, NavDropdown } from \"react-bootstrap\";\nimport \"./NavBar.scss\";\nimport { Link } from 'react-router-dom'\n\nfunction NavBar(props) {\n return (\n <Navbar className=\"nav-bar\">\n <Navbar.Brand id=\"nb-title\" href=\"/\">RANCID TOMATILLOS</Navbar.Brand>\n </Navbar>\n );\n}\n\nexport default NavBar;\n","/Users/demaceovincent/rantom/src/Components/SelectedMovie/SelectedMovie.js",["56"],"import React from \"react\";\nimport \"./SelectedMovie.scss\";\nimport { Link } from \"react-router-dom\";\n\n\nfunction SelectedMovie(props) {\n let genreList = props.genres.map((item) => <li key={Date.now}>{item}</li>);\n return (\n <section className=\"selectedMovie\">\n <h1>{props.title}</h1>\n <h2>{props.tagline}</h2>\n <img\n width=\"100%\"\n src={props.backdrop}\n alt={`backdrop for ${props.title}`}\n />\n <p>Overview: {props.overview}</p>\n <p>Release Date: {props.release}</p>\n <p>Rating: {props.rating}</p>\n <ul>Genres: {genreList}</ul>\n <p>Budget: ${props.budget}</p>\n <p>Revenue: ${props.revenue}</p>\n <p>Duration: {props.runtime} minutes</p>\n </section>\n );\n}\n\nexport default SelectedMovie;\n","/Users/demaceovincent/rantom/src/Components/Catalogue/Catalogue.js",["57"],"import React from \"react\";\nimport MovieCard from \"../MovieCard/MovieCard\";\nimport { Col, Row } from \"react-bootstrap\";\nimport { Link } from 'react-router-dom';\nimport \"./Catalogue.scss\";\n\nfunction Catalogue(props) {\n const movieCards = props.movies.map((movie) => {\n return (\n <Link to={`/movie/${movie.id}`}>\n <MovieCard\n className=\"card\"\n poster={movie.poster_path}\n title={movie.title}\n release={movie.release_date}\n rating={movie.average_rating}\n id={movie.id}\n key={movie.id}\n />\n </Link>\n );\n });\n return (\n <Row className=\"justify-content-md-center\">\n {movieCards}\n </Row>\n );\n}\n\nexport default Catalogue;\n","/Users/demaceovincent/rantom/src/Components/FeaturedMovies/FeaturedMovies.js",[],"/Users/demaceovincent/rantom/src/Components/MovieCard/MovieCard.js",[],"/Users/demaceovincent/rantom/src/Components/Loader/Loader.js",[],"/Users/demaceovincent/rantom/src/Components/Home/Home.js",["58"],"import React from 'react';\nimport FeaturedMovies from '../FeaturedMovies/FeaturedMovies.js';\nimport Catalogue from '../Catalogue/Catalogue.js';\nimport './Home.scss';\n\n\nfunction Home(props) {\n return(\n <React.Fragment>\n {/* <FeaturedMovies /> */}\n <Catalogue\n movies={props.movies}\n \n />\n </React.Fragment>\n )\n}\n\nexport default Home;",{"ruleId":"59","replacedBy":"60"},{"ruleId":"61","replacedBy":"62"},{"ruleId":"63","severity":1,"message":"64","line":2,"column":10,"nodeType":"65","messageId":"66","endLine":2,"endColumn":19},{"ruleId":"63","severity":1,"message":"67","line":6,"column":8,"nodeType":"65","messageId":"66","endLine":6,"endColumn":17},{"ruleId":"63","severity":1,"message":"68","line":10,"column":10,"nodeType":"65","messageId":"66","endLine":10,"endColumn":16},{"ruleId":"63","severity":1,"message":"69","line":10,"column":25,"nodeType":"65","messageId":"66","endLine":10,"endColumn":29},{"ruleId":"63","severity":1,"message":"70","line":2,"column":18,"nodeType":"65","messageId":"66","endLine":2,"endColumn":21},{"ruleId":"63","severity":1,"message":"71","line":2,"column":23,"nodeType":"65","messageId":"66","endLine":2,"endColumn":34},{"ruleId":"63","severity":1,"message":"69","line":4,"column":10,"nodeType":"65","messageId":"66","endLine":4,"endColumn":14},{"ruleId":"63","severity":1,"message":"69","line":3,"column":10,"nodeType":"65","messageId":"66","endLine":3,"endColumn":14},{"ruleId":"63","severity":1,"message":"72","line":3,"column":10,"nodeType":"65","messageId":"66","endLine":3,"endColumn":13},{"ruleId":"63","severity":1,"message":"73","line":2,"column":8,"nodeType":"65","messageId":"66","endLine":2,"endColumn":22},"no-native-reassign",["74"],"no-negated-in-lhs",["75"],"no-unused-vars","'Container' is defined but never used.","Identifier","unusedVar","'Catalogue' is defined but never used.","'Switch' is defined but never used.","'Link' is defined but never used.","'Nav' is defined but never used.","'NavDropdown' is defined but never used.","'Col' is defined but never used.","'FeaturedMovies' is defined but never used.","no-global-assign","no-unsafe-negation"]
Loading