Router refactor #22
Merged
Router refactor #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebCyphers
approved these changes
Dec 9, 2020
| @@ -7,60 +7,53 @@ import Catalogue from "./Components/Catalogue/Catalogue"; | |||
| import { getMovies, getMovie } from "./apiCalls"; | |||
| import "bootstrap/dist/css/bootstrap.min.css"; | |||
| import "./App.scss"; | |||
| import { Switch, Route, Link } from "react-router-dom"; | |||
There was a problem hiding this comment.
If we are not using Switch, we should remove the reference
Comment on lines
+43
to
+47
| <Row className="d-flex justify-content-center"> | ||
| <Col md="auto"> | ||
| {this.state.error && <Alert variant="danger">{this.state.error}</Alert>} | ||
| </Col> | ||
| </Row> |
There was a problem hiding this comment.
love this error handling
| key={movie.id} | ||
| handleClick={props.handleClick} | ||
| /> | ||
| <Link to={`/movie/${movie.id}`}> |
There was a problem hiding this comment.
we need to add a KEY peramiter to these!!!
Comment on lines
-11
to
-12
| src="https://images.unsplash.com/photo-1485846234645-a62644f84728?ixid=MXwxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHw%3D&ixlib=rb-1.2.1&auto=format&fit=crop&w=1940&q=80" | ||
| alt="Movie Clacker" |
There was a problem hiding this comment.
I enjoy the updates to this!
| @@ -1,17 +1,12 @@ | |||
| import React from "react"; | |||
| import { Navbar, Nav, NavDropdown } from "react-bootstrap"; | |||
| import "./NavBar.scss"; | |||
| import { Link } from 'react-router-dom' | |||
There was a problem hiding this comment.
We can remove this I believe
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Where should the reviewer start?
App.js, FeatureMovies.js, SelectedMovie.js
How should this be manually tested?
Click on a MovieCard to be redirected to the SelectedMovie's page.
Any background context you want to provide?
What are the relevant tickets?
Closes #18 #17 #16 #15 #14 #8