Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing cc #25

Merged
merged 5 commits into from
Dec 15, 2020
Merged

Testing cc #25

merged 5 commits into from
Dec 15, 2020

Conversation

CalebCyphers
Copy link
Collaborator

What does this PR do?

  • Adjusts logic within App
  • Reduces mutation of datatypes in state
  • Opens up and refactors tests
  • Builds tests within Home and Catalogue components
  • give keys to list elements

How should this be manually tested?

  • npm test

Any background context you want to provide?

  • I'm not sure why the console is still filling with errors. I hope it's a simple solution, none of my refactors have managed to get rid of them.

What are the relevant tickets?

@CalebCyphers CalebCyphers added testing U KNO WHAT TESTING IS U DINGUS Error Handling labels Dec 15, 2020
@CalebCyphers CalebCyphers self-assigned this Dec 15, 2020
@demaceo
Copy link
Owner

demaceo commented Dec 15, 2020

Do the errors you're seeing in the console involve a missing "key" within a component?

@demaceo demaceo merged commit 2581224 into main Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@demaceo demaceo demaceo approved these changes

Assignees

@CalebCyphers CalebCyphers

Labels
Error Handling testing U KNO WHAT TESTING IS U DINGUS
Projects
None yet
Milestone
Iteration 4 - Refactoring with Router
Development

Successfully merging this pull request may close these issues.

Forward and back arrow navigation
2 participants
@CalebCyphers @demaceo