amelioration : ETQ instructeur, je souhaite pouvoir filtrer les dossiers sur mon tableau de bord fonction des choix simple/multiple/etc.. sans conflit parmis les autres valeurs de ces même choix simple/multiple/etc... #10866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfo
force-pushed
the
US/fix-filter-ilike
branch
from
020360f to
09d5245
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10866 +/- ##
==========================================
+ Coverage 84.68% 84.69% +0.01%
==========================================
Files 1132 1132
Lines 25092 25102 +10
Branches 4702 4703 +1
==========================================
+ Hits 21248 21260 +12
+ Misses 3844 3842 -2 ☔ View full report in Codecov by Sentry. |
mfo
changed the title
…han expected. indead, some enum might overlap on word ex: Favorable, Defavorable. Searching with ilike Favorable finds Defavorable
… it search by exact match since enum are normalized so findable with simple where
mfo
force-pushed
the
US/fix-filter-ilike
branch
from
c05967b to
75063ae
Compare
…en using `where("anything = ?", value)` synthax
mfo
changed the title
mfo
changed the title
LeSim
approved these changes
Oct 3, 2024
Comment on lines
-250
to
-253
| if column == 'label' | ||
| dossiers | ||
| .joins(:groupe_instructeur) | ||
| .filter_ilike(table, column, values) |
There was a problem hiding this comment.
la j'ai l'impression que tu supprimes la possibilité de filtrer par nom du groupe d'instructeur. C'est fait expres ?
There was a problem hiding this comment.
C'est du code mort, confère : https://github.com/demarches-simplifiees/demarches-simplifiees.fr/blob/main/app/models/concerns/columns_concern.rb#L55
Désormais on ne filtre pas sur le label d'un groupe d'instrcuteur (à la ilike), mais par énum
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
via the queue into
demarches-simplifiees:main
with commit Oct 3, 2024
5879d54
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hs: https://secure.helpscout.net/conversation/2708763508/2094915?folderId=1653799
problème
ETQ instructeur, lorsque je veux filtrer par type de champ enumerable (donc ayant une liste finie, ex: une dropdown), dans le cas ou les options de l'enumerable peuvent se confondre (ex: Favorable, Defavorable), j'aimerais filtrer mon tableau de bord par la bonne occurence
solution
Avant on recherchait si la valeur du filtre était présente dans la valeur du type de champ [donc opérateur ilike]
Maintenant on recherche si la valeur du filtre est egale à la valeur du type de champ donc operateur =) :