ETQ instructeur je peux filtrer un champ "choix simple" avec un long libellé d'option #10930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinux
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10930 +/- ##
==========================================
+ Coverage 84.50% 84.51% +0.01%
==========================================
Files 1140 1141 +1
Lines 25246 25263 +17
Branches 4724 4725 +1
==========================================
+ Hits 21334 21351 +17
Misses 3912 3912 ☔ View full report in Codecov by Sentry. |
Notre infra supporte des urls d'au moins 8000 caractères, probablement plus encore, donc on est large.
colinux
force-pushed
the
fix-dropdown-list-filter-length
branch
from
79fc51c to
1c32a30
Compare
tchak
approved these changes
Oct 14, 2024
Merged
via the queue into
demarches-simplifiees:main
with commit Oct 14, 2024
ed6a254
18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notre infra supporte des urls d'au moins 8000 caractères (probablement plus encore), donc on est large et je me demande même de la pertinence de cette limite. (les navigateurs modernes supportent + de 30K caractères)
Régression introduite par #10866
Cf https://secure.helpscout.net/conversation/2729750912/2099226?viewId=3192413