Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin, dans la page "toutes les démarches", je veux que les tags soient harmonisés #10876

Merged
merged 8 commits into from
Oct 14, 2024

Conversation

kara22
Copy link
Contributor

@kara22 kara22 commented Sep 29, 2024

#10333

  1. Le support créé les thématiques qui seront figés. Le support peut associer une thématique à une démarche mais ce n'est pas obligatoire. Le support peut supprimer les éléments de la liste.
image
  1. L'administrateur peut associer une démarche à une ou plusieurs thématiques. Il ne peut pas créer de nouvelle thématique.
image
  1. L'admin peut filtrer dans la page "toutes les démarches" avec la liste des nouvelles thématiques prédéfinies par le support :
image

@kara22 kara22 marked this pull request as draft September 29, 2024 15:18
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 78.94737% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.50%. Comparing base (32d8cbf) to head (4336c44).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...p/controllers/manager/procedure_tags_controller.rb 0.00% 4 Missing ⚠️
...pp/tasks/maintenance/create_procedure_tags_task.rb 84.61% 2 Missing ⚠️
...ntrollers/administrateurs/procedures_controller.rb 87.50% 1 Missing ⚠️
app/dashboards/procedure_tag_dashboard.rb 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10876      +/-   ##
==========================================
- Coverage   84.51%   84.50%   -0.01%     
==========================================
  Files        1136     1140       +4     
  Lines       25207    25244      +37     
  Branches     4718     4724       +6     
==========================================
+ Hits        21303    21332      +29     
- Misses       3904     3912       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kara22 kara22 marked this pull request as ready for review October 3, 2024 12:59
@kara22 kara22 force-pushed the feat/10333 branch 7 times, most recently from b2cd4df to 205504e Compare October 7, 2024 16:47
@kara22 kara22 requested a review from colinux October 7, 2024 16:56
@kara22 kara22 force-pushed the feat/10333 branch 9 times, most recently from f7ffc48 to c263842 Compare October 11, 2024 05:42
@kara22 kara22 requested a review from colinux October 11, 2024 05:58
colinux
colinux previously approved these changes Oct 11, 2024
@colinux colinux dismissed their stale review October 11, 2024 10:12

j'ai trouvé un bug

Copy link
Member

@colinux colinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kara22 j'ai creusé cette histoire de CI qui soi-disant ne passait pas par le controller qui filtrait les tags. Et j'ai eu raison, car effectivement les tests ne passent pas par les filtres et ya un bug ! J'ai rajouté un test qui échoue pour le démontrer : toutes les procédures sont renvoyées, on ne filtre rien. Je te laisserai faire le fix ;)

J'ai aussi rajouté 2 petits commits annexes qui améliorent très légèrement sur le combobox et le wording (indépendants de cette PR, mais ça se voit dans ce contexte).

@kara22 kara22 force-pushed the feat/10333 branch 2 times, most recently from 5eaf103 to ec472b2 Compare October 14, 2024 08:16
@kara22 kara22 added this pull request to the merge queue Oct 14, 2024
Merged via the queue into main with commit 8e1b636 Oct 14, 2024
19 checks passed
@kara22 kara22 deleted the feat/10333 branch October 14, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants