Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETQ admin j'ai une nouvelle interface pour les options de l'instruction #10935

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

E-L-T
Copy link
Contributor

@E-L-T E-L-T commented Oct 15, 2024

Correspond à une partie de #10766

Dans cette PR :

  • On met a jour l'interface de la page Options
  • On ajoute le composant import dans la page de gestion des groupes

Routage inactif et pas de champ routable

AVANT

Capture d’écran 2024-10-15 à 15 14 36

APRÈS

Capture d’écran 2024-10-15 à 15 14 54

Routage inactif et champ routable

AVANT

Capture d’écran 2024-10-15 à 15 15 34

APRÈS

Capture d’écran 2024-10-15 à 15 15 45

Routage actif

AVANT

Capture d’écran 2024-10-15 à 15 16 24

APRÈS

Capture d’écran 2024-10-15 à 15 16 34

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.71%. Comparing base (c10bec3) to head (d979bf6).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
app/models/type_de_champ.rb 33.33% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c10bec3) and HEAD (d979bf6). Click for more details.

HEAD has 8 uploads less than BASE
Flag BASE (c10bec3) HEAD (d979bf6)
16 8
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10935      +/-   ##
==========================================
- Coverage   84.47%   77.71%   -6.77%     
==========================================
  Files        1164     1164              
  Lines       25698    26381     +683     
  Branches     4862     4715     -147     
==========================================
- Hits        21708    20501    -1207     
- Misses       3990     5880    +1890     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@E-L-T E-L-T force-pushed the update-instruction-options-interface branch 3 times, most recently from 363f5a6 to 3187f81 Compare October 15, 2024 13:48
@E-L-T E-L-T marked this pull request as ready for review October 15, 2024 13:58
@E-L-T E-L-T force-pushed the update-instruction-options-interface branch from 3187f81 to 01f0063 Compare October 15, 2024 16:11
Comment on lines 18 to 22
MANAGED_TYPE_DE_CHAMP_BY_CATEGORY = TypeDeChamp::TYPE_DE_CHAMP_TO_CATEGORIE
.filter { |k, _| k.in?(MANAGED_TYPE_DE_CHAMP) }
.map { |k, v| { v => k } }
.flat_map(&:to_a)
.group_by(&:first)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

proposition

Suggested change
MANAGED_TYPE_DE_CHAMP_BY_CATEGORY = TypeDeChamp::TYPE_DE_CHAMP_TO_CATEGORIE
.filter { |k, _| k.in?(MANAGED_TYPE_DE_CHAMP) }
.map { |k, v| { v => k } }
.flat_map(&:to_a)
.group_by(&:first)
MANAGED_TYPE_DE_CHAMP_BY_CATEGORY = MANAGED_TYPE_DE_CHAMP.keys.map(&:to_sym)
.each_with_object(Hash.new { |h,k| h[k] = [] }) do |type, h|
h[TypeDeChamp::TYPE_DE_CHAMP_TO_CATEGORIE[type]] << type
end

Copy link
Contributor Author

@E-L-T E-L-T Nov 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oui très bien ! je fais la modif

@E-L-T E-L-T force-pushed the update-instruction-options-interface branch 2 times, most recently from 934662e to 053910c Compare November 5, 2024 13:37
@E-L-T E-L-T force-pushed the update-instruction-options-interface branch from 053910c to d979bf6 Compare November 5, 2024 13:41
@E-L-T E-L-T added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit a2446c4 Nov 5, 2024
18 checks passed
@E-L-T E-L-T deleted the update-instruction-options-interface branch November 5, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants