Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API graphql: expose les demandes de corrections #9310

Merged
merged 3 commits into from
Jul 21, 2023

Conversation

colinux
Copy link
Member

@colinux colinux commented Jul 12, 2023

  • - renomme DossierCorrection#{kind =>reason} ainsi que sa valeur par défaut correction => incorrect, ce qui permet des méthodes de type correction.dossier_incorrect? ou correction.dossier_incomplete?
  • - l'API expose dateDerniereCorrectionEnAttente au niveau du dossier et le type de correction et sa date de résolution au niveau du message associé
  • Créer une correction en envoyant un message
  • Filtrer les messages pour n'avoir que les demande de correction ? ça me paraît inutile pour le moment

Remarque
La seule différence entre incomplete et incorrect est dans le traitement du SVA, donc dans notre interface instructeur, on expose incomplete uniquement sur les démarches SVA.
Or avec l'API, les 2 types seront exposés pour tout le monde.

@what-the-diff
Copy link

what-the-diff bot commented Jul 12, 2023

PR Summary

  • Enhancements to Correction Request Status
    A new classification system is added to categorize correction requests as 'incomplete' or 'incorrect'. This helps track the type of issues users are having more accurately.

  • Introduction of the 'last pending correction request' date
    A new field has been added to show the date of the most recent pending correction request from a user. This helps monitor pending requests and their timelines more efficiently.

  • Enhancements to Correction Request Tracking
    Keeping track of correction requests is now easier. A change to the default kind attribute makes it easier to identify 'incorrect' correction requests. New tasks and a migration support this change.

  • Improved decision date calculation
    The decision date calculation system now takes the new correction types into account. Utilizing these specifics leads to a more accurate and fair calculation of the duration.

  • Updated Factory and Tests
    The factory used for testing is updated to include a scenario with a pending correction. Additionally, new tests have been added to check the functionality and robustness of the recent updates.

  • Major codebase updates to harmonize with the changes
    Several types, models, and concerns have been updated to fit with the new correction request status classification and 'last pending correction request' date field. New factories and specifications have also been added for these updates.

  • Schema updates
    The updates have been reflected in the schema files. These files lie at the core of the project and help keep track of all the project's objects and their relationships.

@colinux colinux force-pushed the feat-graphql-dossier-corrections branch from 6239d65 to ee3cea5 Compare July 12, 2023 11:46
@colinux colinux force-pushed the feat-graphql-dossier-corrections branch 5 times, most recently from 358c797 to 39868b6 Compare July 13, 2023 16:36
@colinux colinux force-pushed the feat-graphql-dossier-corrections branch 3 times, most recently from 3e83487 to 4b532e1 Compare July 13, 2023 17:02
@colinux colinux marked this pull request as ready for review July 13, 2023 17:15
@tchak tchak force-pushed the feat-graphql-dossier-corrections branch from 4b532e1 to 96ded3e Compare July 19, 2023 09:30
colinux and others added 3 commits July 21, 2023 16:45
@tchak tchak force-pushed the feat-graphql-dossier-corrections branch from 96ded3e to caf41a8 Compare July 21, 2023 14:45
@tchak tchak enabled auto-merge July 21, 2023 14:49
@tchak tchak added this pull request to the merge queue Jul 21, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 21, 2023
@tchak tchak added this pull request to the merge queue Jul 21, 2023
Merged via the queue into main with commit 03da572 Jul 21, 2023
@tchak tchak deleted the feat-graphql-dossier-corrections branch July 21, 2023 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants