Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: supprime la colonne dossier_corrections#kind #9316

Merged

Conversation

colinux
Copy link
Member

@colinux colinux commented Jul 13, 2023

Suite et fin d'un renommage de colonne fait dans
#9310

Cette colonne kind avait été remplacée par reason

@what-the-diff
Copy link

what-the-diff bot commented Jul 13, 2023

PR Summary

  • Change in Parameter Name and Value in Forms
    The parameters in the 'construction_menu' form element and 'dossiers_controller' have been changed for clarity. 'kind' was replaced with 'reason' and 'incomplete' is now an identified reason.

  • Addition of New Arguments and Types
    There's been a new argument addition to the 'DossierEnvoyerMessage' mutation, allowing the creation of corrections with specified reasons. New GraphQL objects and an enum for 'CorrectionType' and 'CorrectionReason' respectively have been added for this purpose.

  • Updates in Dossier GraphQL Object
    The 'Dossier' GraphQL object has been updated to include a new date field 'dateDerniereCorrectionEnAttente' which most likely indicates the date of the last pending correction.

  • Updates in Translations
    New translation keys have been added to meet the changing need of 'reasons' for 'DossierCorrection' in both English and French.

  • Changes in HTML Structure
    The structure of HTML in 'notify_pending_correction' template has been updated to use the new 'reason' translation keys.

  • Database Changes
    New database migrations have been added to add, remove, and backfill the 'reason' column in 'dossier_corrections' as required.

  • Addition of New Tests
    New tests have been incorporated to ensure the new functionality works as expected. These tests span across various controllers, models, GraphQL, and mailer specs.

  • Modification in Test Cases
    Certain modifications have been put in place to existing tests for dossier_spec and sva_svr_decision_date_calculator_service. The modifications include changes in test description and additional assertions.

@colinux colinux force-pushed the drop-dossier-correction-columns branch 2 times, most recently from 4534e14 to cbbc939 Compare July 13, 2023 17:18
@colinux colinux force-pushed the drop-dossier-correction-columns branch 3 times, most recently from 3727ef2 to 071f3d3 Compare July 27, 2023 14:19
@colinux colinux marked this pull request as ready for review July 27, 2023 14:19
@colinux colinux force-pushed the drop-dossier-correction-columns branch from 071f3d3 to f2afe50 Compare July 27, 2023 14:31
@colinux colinux added this pull request to the merge queue Jul 31, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 31, 2023
@colinux colinux added this pull request to the merge queue Jul 31, 2023
Merged via the queue into demarches-simplifiees:main with commit d331c47 Jul 31, 2023
@colinux colinux deleted the drop-dossier-correction-columns branch July 31, 2023 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants