Nestjs #1755
Merged
Nestjs #1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er types, more declarative
|
I'd like to wait on the dfx extensions PR #1759, maybe it will resolve the replica issue with large_files |
lastmjs
commented
Apr 25, 2024
lastmjs
commented
Apr 26, 2024
bdemann
requested changes
Apr 26, 2024
…he uploader agent for reloadjs as well
bdemann
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1754
This implements the changes necessary to allow NestJS to work to an unknown extent. There is also an example with tests.
Working on this PR also opened my eyes to some easy-to-fix latencies in the reload js/autoreload functionality. The tests were not passing either because of how long it took, so I addressed that.