Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement the azle dfx extension and update all example projects #1759

Merged
merged 14 commits into from
Apr 25, 2024

Conversation

lastmjs
Copy link
Member

@lastmjs lastmjs commented Apr 23, 2024

Closes #1029
Closes #1124

This implements the initial Azle extension! All examples with working tests have been updated to use the extension. Documentation is out-of-scope and will be done in a later PR, there's like one little documentation change in here.

Some questions to be answered with design discussions during review:

  • Should we keep the npx azle install-dfx-extension command? Is there some more appropriate way to install the extension? (The decision is this: we will keep the manual installation for now, because dfx start does not work inside of a directory with a dfx.json file with an extension that hasn't been installed. This means that the extension must be installed before the user runs dfx start. I'm not sure if there's a good automatic way to do this right now)
  • What do we do about naming clashes between dfx and Azle in the dfx.json? (We should probably nest azle-specific commands, let's wait on dfinity providing a nice nesting structure? We could always move forward on this now though, which might be a good idea because we're introducing breaking changes now anyway)
  • When should we release this? Should we merge this now? It's going to take a few weeks before this comes out in a dfx release with a hard number, but we could use the release that we're using for testing

@lastmjs lastmjs marked this pull request as ready for review April 24, 2024 13:06
@lastmjs lastmjs mentioned this pull request Apr 24, 2024
src/compiler/utils/get_canister_config.ts Outdated Show resolved Hide resolved
src/compiler/utils/get_canister_config.ts Show resolved Hide resolved
src/lib/fetch/icp.ts Show resolved Hide resolved
examples/rejections/src/rejections/index.ts Show resolved Hide resolved
examples/cycles/test/pretest.ts Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
examples/rejections/test/pretest.ts Show resolved Hide resolved
publish-github-action.sh Show resolved Hide resolved
src/compiler/index.ts Outdated Show resolved Hide resolved
src/compiler/index.ts Show resolved Hide resolved
src/compiler/utils/get_canister_config.ts Outdated Show resolved Hide resolved
src/compiler/utils/get_canister_config.ts Show resolved Hide resolved
examples/composite_queries/dfx.json Outdated Show resolved Hide resolved
src/lib/fetch/icp.ts Show resolved Hide resolved
examples/rejections/src/rejections/index.ts Show resolved Hide resolved
dfx_extension/extension.json Outdated Show resolved Hide resolved
dfx_extension/install.sh Outdated Show resolved Hide resolved
dfx_extension/install.sh Show resolved Hide resolved
publish-github-action.sh Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
src/compiler/get_candid_and_canister_methods.ts Outdated Show resolved Hide resolved
src/compiler/index.ts Outdated Show resolved Hide resolved
@lastmjs lastmjs merged commit fdbdccc into main Apr 25, 2024
122 of 126 checks passed
@lastmjs lastmjs deleted the dfx_extensions branch July 19, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dfx extensions gzip and metadata
2 participants