fix(SEKOIAIntelligenceCenter): fix endpoint for test command #24437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
content-bot
changed the base branch from
master
to
contrib/SEKOIA-IO_sekoia-io-cti-fix-wrong-test-endpoint
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @yaakovpraisler will know he can start review the proposed changes. |
content-bot
added
Contribution Form Filled
…' into sekoia-io-cti-fix-wrong-test-endpoint
yaakovpraisler
requested changes
Feb 8, 2023
There was a problem hiding this comment.
Hi @PierrickV - Thank for fixing it! good job :)
Please bump the version of the pack in the pack_metadata.json file and we'll continue to merge.
yaakovpraisler
added
the
pending-contributor
PierrickV
force-pushed
the
sekoia-io-cti-fix-wrong-test-endpoint
branch
from
2908083 to
a97444d
Compare
Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
PierrickV
force-pushed
the
sekoia-io-cti-fix-wrong-test-endpoint
branch
from
a97444d to
6739944
Compare
|
@yaakovpraisler : thank you for taking the time to review this work! I applied your suggestions 😸 |
…' into sekoia-io-cti-fix-wrong-test-endpoint
yaakovpraisler
approved these changes
Feb 8, 2023
yaakovpraisler
merged commit 81fdd3a
into
demisto:contrib/SEKOIA-IO_sekoia-io-cti-fix-wrong-test-endpoint
11 tasks
yaakovpraisler
added a commit
that referenced
this pull request
Feb 8, 2023
…#24485) * fix(SEKOIAIntelligenceCenter): fix endpoint for test command * Apply suggestions from code review by @yaakovpraisler --------- Co-authored-by: lilyus <8960084+PierrickV@users.noreply.github.com> Co-authored-by: Yaakov Praisler <59408745+yaakovpraisler@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Wrong endpoint was called for
test-moduleresulting in aToken revokederrorDescription
Fix issue
Screenshots
Before (red) after (green)
Minimum version of Cortex XSOAR
Does it break backward compatibility?
Must have