Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SEKOIAIntelligenceCenter): fix endpoint for test command #24437

Merged
merged 4 commits into from
Feb 8, 2023
Merged

fix(SEKOIAIntelligenceCenter): fix endpoint for test command #24437

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d483dff
fix(SEKOIAIntelligenceCenter): fix endpoint for test command
PierrickV Feb 7, 2023
f2b204d
Merge branch 'contrib/SEKOIA-IO_sekoia-io-cti-fix-wrong-test-endpoint…
PierrickV Feb 7, 2023
6739944
Apply suggestions from code review by @yaakovpraisler
PierrickV Feb 8, 2023
3be5076
Merge branch 'contrib/SEKOIA-IO_sekoia-io-cti-fix-wrong-test-endpoint…
PierrickV Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...EKOIAIntelligenceCenter/Integrations/SEKOIAIntelligenceCenter/SEKOIAIntelligenceCenter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def get_validate_resource(self) -> str:
try:
self._http_request(
method="GET",
url_suffix="/v1/apiauth/auth/validate",
url_suffix="/v1/auth/validate",
raise_on_status=True,
)
return "ok"
Expand Down
2 changes: 1 addition & 1 deletion ...KOIAIntelligenceCenter/Integrations/SEKOIAIntelligenceCenter/SEKOIAIntelligenceCenter.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,7 +1295,7 @@ script:
script: '-'
type: python
subtype: python3
dockerimage: demisto/py3-tools:1.0.0.47376
dockerimage: demisto/py3-tools:1.0.0.47433
fromversion: 6.2.0
tests:
- No tests (auto formatted)
4 changes: 2 additions & 2 deletions ...IntelligenceCenter/Integrations/SEKOIAIntelligenceCenter/SEKOIAIntelligenceCenter_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_test_module_ok(client, requests_mock):
"user_claims": None,
}

requests_mock.get(MOCK_URL + "/v1/apiauth/auth/validate", json=response)
requests_mock.get(MOCK_URL + "/v1/auth/validate", json=response)
assert SEKOIAIntelligenceCenter.test_module(client) == "ok"


Expand All @@ -105,7 +105,7 @@ def test_test_module_ok(client, requests_mock):
)
def test_test_module_nok(client, requests_mock, api_response, expected):
requests_mock.get(
MOCK_URL + "/v1/apiauth/auth/validate", json=api_response, status_code=401
MOCK_URL + "/v1/auth/validate", json=api_response, status_code=401
)

assert expected in SEKOIAIntelligenceCenter.test_module(client)
Expand Down
5 changes: 5 additions & 0 deletions Packs/SEKOIAIntelligenceCenter/ReleaseNotes/1_2_1.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@

#### Integrations
##### SEKOIAIntelligenceCenter
- Fix endpoint for test command
PierrickV marked this conversation as resolved.
Show resolved Hide resolved
- Updated the Docker image to: *demisto/py3-tools:1.0.0.47433*.