Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align credentials stores part 17 #27433

Merged
merged 17 commits into from
Jun 22, 2023
Merged

Conversation

maimorag
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Relates: link to the issue

Description

Change the type of credentials, from type 4 to type 9.

Minimum version of Cortex XSOAR

  • 6.5.0

Does it break backward compatibility?

  • No

@maimorag
Copy link
Contributor Author

The build fails since there is no instance [IN140] for:

  • Pipl
  • Twilio

@maimorag maimorag requested a review from Shellyber June 18, 2023 13:10
@maimorag maimorag requested a review from Shellyber June 20, 2023 10:13
Packs/Twilio/ReleaseNotes/1_0_5.md Outdated Show resolved Hide resolved
Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>
@maimorag maimorag added the ForceMerge Forcing the merge of the PR despite the build status label Jun 20, 2023
Packs/Pipl/Integrations/Pipl/Pipl.js Outdated Show resolved Hide resolved
Packs/Pipl/Integrations/Pipl/Pipl.js Outdated Show resolved Hide resolved
Packs/Twilio/Integrations/Twilio/Twilio.js Outdated Show resolved Hide resolved
maimorag and others added 3 commits June 21, 2023 10:26
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
@maimorag maimorag requested a review from dantavori June 21, 2023 10:04
Packs/Pipl/Integrations/Pipl/Pipl.js Outdated Show resolved Hide resolved
Packs/Twilio/Integrations/Twilio/Twilio.js Outdated Show resolved Hide resolved
maimorag and others added 2 commits June 22, 2023 14:01
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
@dantavori dantavori merged commit 0d72afc into master Jun 22, 2023
@dantavori dantavori deleted the align_credentials_stores_part_17 branch June 22, 2023 12:19
MosheEichler pushed a commit that referenced this pull request Jul 2, 2023
* Align credentials stores part 17

* Twilio

* RM110 fix

* fix RL

* Update Packs/Twilio/Integrations/Twilio/Twilio.js

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>

* cr notes

* undo changes

* fix this

* Update Packs/Twilio/ReleaseNotes/1_0_5.md

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>

* Update Packs/Pipl/Integrations/Pipl/Pipl.js

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* Pipl fix js

* dan fix

* fix

* Update Packs/Pipl/Integrations/Pipl/Pipl.js

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* Update Packs/Twilio/Integrations/Twilio/Twilio.js

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

---------

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Jul 26, 2023
* Align credentials stores part 17

* Twilio

* RM110 fix

* fix RL

* Update Packs/Twilio/Integrations/Twilio/Twilio.js

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>

* cr notes

* undo changes

* fix this

* Update Packs/Twilio/ReleaseNotes/1_0_5.md

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>

* Update Packs/Pipl/Integrations/Pipl/Pipl.js

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* Pipl fix js

* dan fix

* fix

* Update Packs/Pipl/Integrations/Pipl/Pipl.js

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

* Update Packs/Twilio/Integrations/Twilio/Twilio.js

Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>

---------

Co-authored-by: Shelly Tzohar <45915502+Shellyber@users.noreply.github.com>
Co-authored-by: Dan Tavori <38749041+dantavori@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ForceMerge Forcing the merge of the PR despite the build status
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants